From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47959) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RyOah-0003OO-05 for qemu-devel@nongnu.org; Fri, 17 Feb 2012 09:15:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RyOaa-0006pJ-Br for qemu-devel@nongnu.org; Fri, 17 Feb 2012 09:15:14 -0500 Received: from cantor2.suse.de ([195.135.220.15]:40402 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RyOaa-0006oa-2Z for qemu-devel@nongnu.org; Fri, 17 Feb 2012 09:15:08 -0500 Message-ID: <4F3E60EA.4080801@suse.de> Date: Fri, 17 Feb 2012 15:15:06 +0100 From: Hannes Reinecke MIME-Version: 1.0 References: <1329467461-32083-1-git-send-email-hare@suse.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH][v11] megasas: LSI Megaraid SAS HBA emulation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerhard Wiesinger Cc: Alexander Graf , qemu-devel@nongnu.org, Andreas Faerber On 02/17/2012 03:03 PM, Gerhard Wiesinger wrote: > Hello Hannes, >=20 > Reason for my problems of non working megasas is that megasas.o was > no compiled: >=20 > Details: > Makefile.objs > #hw-obj-$(CONFIG_MEGASAS_SCSI_PCI) +=3D megasas.o > # OK: > hw-obj-y +=3D megasas.o >=20 > Although: > ./default-configs/pci.mak:CONFIG_MEGASAS_SCSI_PCI=3Dy >=20 > Did also a new configure run. >=20 > Any ideas? >=20 > Errors with the patch: > /root/download/qemu/git/qemu-kvm/hw/megasas.c: In function > .megasas_init_firmware.: > /root/download/qemu/git/qemu-kvm/hw/megasas.c:568:14: error: > variable .reply_queue_tail. set but not used > [-Werror=3Dunused-but-set-variable] > /root/download/qemu/git/qemu-kvm/hw/megasas.c:565:28: error: > variable .iq_pl. set but not used [-Werror=3Dunused-but-set-variable] > /root/download/qemu/git/qemu-kvm/hw/megasas.c: In function > .megasas_dcmd_ld_get_list.: > /root/download/qemu/git/qemu-kvm/hw/megasas.c:995:32: error: > variable .max_ld_disks. set but not used > [-Werror=3Dunused-but-set-variable] > /root/download/qemu/git/qemu-kvm/hw/megasas.c: In function > .megasas_handle_dcmd.: > /root/download/qemu/git/qemu-kvm/hw/megasas.c:1203:17: error: > variable .size. set but not used [-Werror=3Dunused-but-set-variable] > /root/download/qemu/git/qemu-kvm/hw/megasas.c: In function > .megasas_xfer_complete.: > /root/download/qemu/git/qemu-kvm/hw/megasas.c:1386:14: error: > variable .bytes_left. set but not used > [-Werror=3Dunused-but-set-variable] > /root/download/qemu/git/qemu-kvm/hw/megasas.c: In function > .megasas_handle_frame.: > /root/download/qemu/git/qemu-kvm/hw/megasas.c:1490:13: error: > variable .frame_cmd. set but not used [-Werror=3Dunused-but-set-variabl= e] > /root/download/qemu/git/qemu-kvm/hw/megasas.c: At top level: > /root/download/qemu/git/qemu-kvm/hw/megasas.c:1872:1: error: data > definition has no type or storage class [-Werror] > /root/download/qemu/git/qemu-kvm/hw/megasas.c:1872:1: error: type > defaults to .int. in declaration of .type_init. [-Werror=3Dimplicit-int= ] > /root/download/qemu/git/qemu-kvm/hw/megasas.c:1872:1: error: > parameter names (without types) in function declaration [-Werror] > /root/download/qemu/git/qemu-kvm/hw/megasas.c:1867:13: error: > .megaraid1078_register_types. defined but not used > [-Werror=3Dunused-function] > cc1: all warnings being treated as errors >=20 > gcc --version > gcc (GCC) 4.6.2 20111027 (Red Hat 4.6.2-1) >=20 > Please submit a new patch which removes unused variables, etc. >=20 As already mentioned, this patch is against qemu.git, not qemu-kvm.git. The latter doesn't (yet) have the infrastructure changes, so obviously it won't compile there. For the unused variables I'll be updating the patch. Cheers, Hannes --=20 Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: J. Hawn, J. Guild, F. Imend=F6rffer, HRB 16746 (AG N=FCrnberg)