From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:52931) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RyPTi-0003gB-U3 for qemu-devel@nongnu.org; Fri, 17 Feb 2012 10:12:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RyPTe-0000Ue-Hj for qemu-devel@nongnu.org; Fri, 17 Feb 2012 10:12:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50224) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RyPTe-0000UY-Az for qemu-devel@nongnu.org; Fri, 17 Feb 2012 10:12:02 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1HFC1bU010354 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 17 Feb 2012 10:12:01 -0500 Message-ID: <4F3E6E3F.4070300@redhat.com> Date: Fri, 17 Feb 2012 16:11:59 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1329414355-26909-1-git-send-email-alevy@redhat.com> In-Reply-To: <1329414355-26909-1-git-send-email-alevy@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] hw/qxl: allow vram to be sized to 4096 bytes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alon Levy Cc: qemu-devel@nongnu.org Hi, > - if (qxl->vram_size < 16 * 1024 * 1024) { > + /* a request of 0 vram_size is translated to the smallest vram that doesn't > + * break current off screen surfaces using drivers */ > + if (qxl->vram_size > 0 && qxl->vram_size < 16 * 1024 * 1024) { Is there any reason to keep the 16MB minimum size? I think we can just drop it and simplify the logic here. See the patch series just sent. cheers, Gerd