From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53460) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RyQk3-0005UQ-PX for qemu-devel@nongnu.org; Fri, 17 Feb 2012 11:33:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RyQjx-0007ts-Tu for qemu-devel@nongnu.org; Fri, 17 Feb 2012 11:33:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:29002) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RyQjx-0007to-Kl for qemu-devel@nongnu.org; Fri, 17 Feb 2012 11:32:57 -0500 Message-ID: <4F3E8130.10908@redhat.com> Date: Fri, 17 Feb 2012 09:32:48 -0700 From: Eric Blake MIME-Version: 1.0 References: <4F333AAA.1070601@cn.fujitsu.com> <4F333D4B.6090300@cn.fujitsu.com> <4F3AA11C.50408@siemens.com> <4F3E1546.9090303@cn.fujitsu.com> In-Reply-To: <4F3E1546.9090303@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigFA8E9ECDCD40F0A4F2B2A903" Subject: Re: [Qemu-devel] [RFC][PATCH 09/16 v6] introduce a new monitor command 'dump' to dump guest's memory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wen Congyang Cc: Jan Kiszka , HATAYAMA Daisuke , Dave Anderson , qemu-devel , Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigFA8E9ECDCD40F0A4F2B2A903 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 02/17/2012 01:52 AM, Wen Congyang wrote: > At 02/15/2012 01:59 AM, Jan Kiszka Wrote: >> On 2012-02-09 04:28, Wen Congyang wrote: >>> Signed-off-by: Wen Congyang >>> +static DumpState *dump_init(int fd, Error **errp) >>> +{ >>> + CPUState *env; >>> + DumpState *s =3D dump_get_current(); >>> + int ret; >>> + >>> + vm_stop(RUN_STATE_PAUSED); >> >> I would save the current vm state first and restore it when finished. >=20 > There is no API to get current vm state. If you want this feature, I wi= ll > add API to get it. >=20 > Thanks > Wen Congyang Maybe it's just me, and you can ignore me if I'm speaking out of turn for expressing my views on list netiquette, but... I get frustrated by lengthy messages that are heavily re-quoted versions of earlier versions, with only a very little new content embedded in the middle where I have to hunt for it. There's nothing wrong with using the Delete key to trim replies down to relevant portions, which reduces the bandwidth of the list engine as well as reduces the time spent in reviewing email exchanges. /me returns back to lurk mode, but with one additional observation: There are other APIs where qemu has ended up pausing the domain and not restoring things back to running when done, and where libvirt has had to track existing state prior to starting actions in order to manually fix things after the fact (see libvirt's qemudDomainCoreDump as a wrapper around migration to file, for an example). If we do things right in this new DumpState API, we may want to decide to fix other monitor commands to use the same mechanism (it won't offload any of the burden from libvirt, which must still correctly interact with older qemu, but would make life nicer for clients that can assume the saner semantics). --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigFA8E9ECDCD40F0A4F2B2A903 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPPoExAAoJEKeha0olJ0NqNIIIAJ4i/uI5Fpvf9cdUEhRb5nai LAAZ8vjvXpTFEsarnlF3ioVe4fBTT6ikndcihYB4KSgISy67yQH+7ebtmGKUY48t 4xxp/7YAOrZ96ogV4czk+UIMsbtJgHwxoDWbhz4LhqJI9pI/WhKlkCEmmWKaocLw IpjmKs3KXBTjm3wExr4Zyl4x2wbEOwiM6EwfetB5sU82ey6Bplod2ekXkMR4lzAH e3oJXxBgPDEPUDuWHgN39YMXiezw8AFpmOarD+t6GGXRgFcyzQCh49qzlu2xJudC QY5RYWzHI/uHX8BM2/pRVkQY0iXnwSsCVPRstpbWJCJUFIyfqWJbn/AoSV02ZJE= =y8JL -----END PGP SIGNATURE----- --------------enigFA8E9ECDCD40F0A4F2B2A903--