From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54097) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RySDR-0006KS-8G for qemu-devel@nongnu.org; Fri, 17 Feb 2012 13:07:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RySDN-0000tP-0d for qemu-devel@nongnu.org; Fri, 17 Feb 2012 13:07:29 -0500 Received: from cantor2.suse.de ([195.135.220.15]:50625 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RySDM-0000t6-PA for qemu-devel@nongnu.org; Fri, 17 Feb 2012 13:07:24 -0500 Message-ID: <4F3E975A.3050206@suse.de> Date: Fri, 17 Feb 2012 19:07:22 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1329347774-23262-1-git-send-email-imammedo@redhat.com> <1329347774-23262-3-git-send-email-imammedo@redhat.com> <4F3D2A2A.9040002@suse.de> <4F3E8B60.80103@redhat.com> In-Reply-To: <4F3E8B60.80103@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: jan.kiszka@siemens.com, qemu-devel@nongnu.org, gleb@redhat.com Am 17.02.2012 18:16, schrieb Igor Mammedov: > On 02/16/2012 05:09 PM, Andreas F=E4rber wrote: >> We should have a single code path through which we instantiate >> CPUs, currently: cpu_$arch_init(const char *cpu_model) >> With my series completed, this would return an X86CPU object. >> >> Depending on our liking, we could either place some ICC / APIC / >> whatever fields directly into that, or embed the X86CPU in an object >> such as yours above as a link. I do feel however that the mode= l >> string is misplaced there. Question is whether this ICC stuff is >> actually part of the CPU or part of the CPU wiring on the mainboard - = I >> vaguely remember someone saying that this changed over time...? Having > Yep, since P4 times sysbus used instead of icc so we can just ignore ic= c. >=20 >> both depending on CPU subclass might also be an option, but I'd rather >> leave such decisions as a follow-up to the core QOM'ification. >> >=20 > With QOM and your work this patch is obsolete. I see you've already > QOM-ified X86CPU in your qom-cpu tree. Yeah, I postponed PowerPC and took a shortcut by renaming cpuid.c. ;) > With your permission I'll play with it and > check > what could be done for cpu hot-plug feature. Sure, just beware that I frequently rebase this branch based on feedback or moving upstream. Also note that the CPUArchState refactoring is meant only temporary (I'm using a script for that) and should be avoided in new code in favor of CPUX86State or X86CPU/X86CPUClass. If you need some change to make your hotplug work easier, just let me kno= w. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg