From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: linux-can@vger.kernel.org
Subject: Re: [PATCH v2] can: sja1000 fix isr hang when hw is unplugged under load
Date: Fri, 17 Feb 2012 21:27:24 +0100 [thread overview]
Message-ID: <4F3EB82C.7080905@pengutronix.de> (raw)
In-Reply-To: <4F3BE2AC.9020108@hartkopp.net>
[-- Attachment #1: Type: text/plain, Size: 1019 bytes --]
On 02/15/2012 05:51 PM, Oliver Hartkopp wrote:
> In the case of hotplug enabled devices (PCMCIA/PCIeC) the removal of the
> hardware can cause an infinite loop in the common sja1000 isr.
>
> Use the already retrieved status register to indicate a possible hardware
> removal and double check by reading the mode register in sja1000_is_absent.
>
> v2: Create a new function to not print information in irq context.
>
> Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Thanks for the patch. I'm going to commit it to can-next. Any objections?
Marc
P.S.:
Please make it based on can-next/master next time, it fails to apply due
to Wolfgang's dev_LEVEL -> netdev_LEVEL patch. But it's trivial to
apply, by hand :)
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2012-02-17 20:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-13 11:42 [PATCH] MAINTAINERS: can: the mailinglist moved to vger.kernel.org Marc Kleine-Budde
2011-10-13 20:17 ` Oliver Hartkopp
2011-11-02 20:55 ` [PATCH] MAINTAINERS: Add can-gw include to maintained files Oliver Hartkopp
2011-11-03 22:12 ` David Miller
2012-02-14 19:27 ` [PATCH] can: sja1000 fix isr hang when hw is unplugged under load Oliver Hartkopp
2012-02-15 16:51 ` [PATCH v2] " Oliver Hartkopp
2012-02-17 20:27 ` Marc Kleine-Budde [this message]
2012-02-18 14:19 ` Oliver Hartkopp
2012-02-18 17:00 ` Marc Kleine-Budde
2012-02-20 11:02 ` Marc Kleine-Budde
2012-02-21 8:07 ` Oliver Hartkopp
2012-02-21 9:03 ` Marc Kleine-Budde
2012-02-18 14:33 ` Wolfgang Grandegger
2012-02-18 15:34 ` Oliver Hartkopp
2012-02-18 16:44 ` Wolfgang Grandegger
2012-02-18 17:00 ` Marc Kleine-Budde
2012-02-18 17:13 ` Wolfgang Grandegger
2012-03-25 6:43 ` [PATCH] iwlwifi: fix unused variable warning Oliver Hartkopp
2012-03-26 1:49 ` Guy, Wey-Yi
2012-04-03 19:56 ` [PATCH RFC] can: add hash table for single EFF id filter list Oliver Hartkopp
2012-05-08 20:20 ` [PATCH] can: update documentation wording error frames -> error messages Oliver Hartkopp
2012-05-08 20:38 ` Marc Kleine-Budde
2012-05-09 17:09 ` Heinz-Jürgen Oertel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3EB82C.7080905@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.