From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40855) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RyUxm-0003bg-Hv for qemu-devel@nongnu.org; Fri, 17 Feb 2012 16:03:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RyUxl-0002uQ-B6 for qemu-devel@nongnu.org; Fri, 17 Feb 2012 16:03:30 -0500 Received: from cantor2.suse.de ([195.135.220.15]:56446 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RyUxl-0002uB-5A for qemu-devel@nongnu.org; Fri, 17 Feb 2012 16:03:29 -0500 Message-ID: <4F3EC09E.2060603@suse.de> Date: Fri, 17 Feb 2012 22:03:26 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1329506837-30084-1-git-send-email-hpoussin@reactos.org> <1329506837-30084-3-git-send-email-hpoussin@reactos.org> In-Reply-To: <1329506837-30084-3-git-send-email-hpoussin@reactos.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 2/3] jazz-led: convert to QOM List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= Cc: Anthony Liguori , qemu-devel@nongnu.org Am 17.02.2012 20:27, schrieb Herv=C3=A9 Poussineau: > Some simplifications in I/O functions are possible because > Jazz LED only registers one byte of I/O. >=20 > Signed-off-by: Herv=C3=A9 Poussineau > --- > hw/jazz_led.c | 159 +++++++++++++++++++++++++-----------------------= -------- > hw/mips.h | 3 - > hw/mips_jazz.c | 2 +- > 3 files changed, 71 insertions(+), 93 deletions(-) >=20 > diff --git a/hw/jazz_led.c b/hw/jazz_led.c > index 1af9268..5d8040b 100644 > --- a/hw/jazz_led.c > +++ b/hw/jazz_led.c > @@ -1,7 +1,7 @@ > /* > * QEMU JAZZ LED emulator. > * > - * Copyright (c) 2007 Herv=C3=A9 Poussineau > + * Copyright (c) 2007-2012 Herve Poussineau Did you intentionally drop the accent from your name? > +static void jazz_led_register(void) The convention recently introduced would be jazz_led_register_types. > +{ > + type_register_static(&jazz_led_info); > +} > + > +type_init(jazz_led_register); No semicolon necessary. The ops change looks good, and we're still stuck with SysBus for a bit so just these minor nits. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg