From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] integrator: rewrite the AP PCI driver
Date: Sat, 18 Feb 2012 16:26:21 +0100 [thread overview]
Message-ID: <4F3FC31D.7000706@aribaud.net> (raw)
In-Reply-To: <1327948605-9925-1-git-send-email-linus.walleij@linaro.org>
Hi Linus,
Le 30/01/2012 19:36, Linus Walleij a ?crit :
> The PCI support for the Integrator AP has apparently never
> been finished and I strongly suspect that it has never worked,
> so let's fix it. This is a list of the more or less
> un-splittable changes done in this driver rewrite:
>
> - Replace the register definitions stashed into the config
> file (!) with a copy if the register file from the Linux
> kernels arch/arm/include/asm/hardware/pci_v3.h
>
> - Delete the unreadable gigantic macros that perform the
> config accesses and replace them with copyedited code from
> Linux arch/arm/mach-integrator/pci_v3.c
>
> - Rewrite the rest of the setup code to use the
> v3_[read|write][lwb]() accessors.
>
> - Enable PCI by default in the AP board configuration.
>
> - Fix checkpatch warnings and make code more conformant.
>
> Tested-by: Will Deacon<will.deacon@arm.com>
> Signed-off-by: Linus Walleij<linus.walleij@linaro.org>
> ---
> board/armltd/integrator/pci.c | 582 ++++++++++++++++++++++----------------
> board/armltd/integrator/pci_v3.h | 200 +++++++++++++
> include/configs/integratorap.h | 148 +---------
> 3 files changed, 538 insertions(+), 392 deletions(-)
> create mode 100644 board/armltd/integrator/pci_v3.h
Considering it is a bugfix that only touches boards maintained by yourself:
Applied to u-boot-arm/master, thanks.
Note: for some reason this patch appears twice in patchwork, with
identical content and only different submission dates. I have rejected
http://patchwork.ozlabs.org/patch/138700/ and accepted
http://patchwork.ozlabs.org/patch/138700/ as rejected.
Amicalement,
--
Albert.
next prev parent reply other threads:[~2012-02-18 15:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 18:36 [U-Boot] [PATCH] integrator: rewrite the AP PCI driver Linus Walleij
2012-02-18 15:26 ` Albert ARIBAUD [this message]
2012-02-18 15:27 ` Albert ARIBAUD
2012-02-18 17:50 ` Albert ARIBAUD
2012-02-20 6:04 ` Linus Walleij
-- strict thread matches above, loose matches on Subject: below --
2012-01-30 23:49 Linus Walleij
2012-03-03 15:28 ` Wolfgang Denk
2012-03-03 20:27 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3FC31D.7000706@aribaud.net \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.