From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40948) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RynDk-00005X-A3 for qemu-devel@nongnu.org; Sat, 18 Feb 2012 11:33:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RynDg-0005EX-Rz for qemu-devel@nongnu.org; Sat, 18 Feb 2012 11:33:12 -0500 Received: from cantor2.suse.de ([195.135.220.15]:40125 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RynDg-0005E1-H9 for qemu-devel@nongnu.org; Sat, 18 Feb 2012 11:33:08 -0500 Message-ID: <4F3FD2C1.4060409@suse.de> Date: Sat, 18 Feb 2012 17:33:05 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1329498198-6009-1-git-send-email-meadori@codesourcery.com> <4F3E8903.6040807@suse.de> In-Reply-To: <4F3E8903.6040807@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 1/1] exec: Fix watchpoint implementation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Meador Inge Cc: Jan Kiszka , qemu-devel@nongnu.org, Max Filippov Am 17.02.2012 18:06, schrieb Andreas F=E4rber: > Am 17.02.2012 18:03, schrieb Meador Inge: >> Fix a bug introduced by commit 1ec9b909ff207a44d5ef2609cb4a2e3d449d485= f >> where 'watch_mem_write' was modified to fall-through to 'abort' on >> every input. >> >> Signed-off-by: Meador Inge >=20 > Reviewed-by: Andreas F=E4rber Actually I already reviewed such a fix by Max on Jan 29 (with breaks from the start), and it's in his PULL request now. So this is again a duplicate and shouldn't be applied. If you want to remind maintainers of a patch that's been on the list but has not yet been applied, the correct procedure is to add a Reviewed-by or Acked-by tag if you haven't already, or to reply with a "Ping?" otherwise. Andreas >> --- >> * Changes since v1: >> - 'break' out of switch statement instead of 'return'. >> exec.c | 12 +++++++++--- >> 1 files changed, 9 insertions(+), 3 deletions(-) >> >> diff --git a/exec.c b/exec.c >> index b81677a..f105b43 100644 >> --- a/exec.c >> +++ b/exec.c >> @@ -3289,9 +3289,15 @@ static void watch_mem_write(void *opaque, targe= t_phys_addr_t addr, >> { >> check_watchpoint(addr & ~TARGET_PAGE_MASK, ~(size - 1), BP_MEM_WR= ITE); >> switch (size) { >> - case 1: stb_phys(addr, val); >> - case 2: stw_phys(addr, val); >> - case 4: stl_phys(addr, val); >> + case 1: >> + stb_phys(addr, val); >> + break; >> + case 2: >> + stw_phys(addr, val); >> + break; >> + case 4: >> + stl_phys(addr, val); >> + break; >> default: abort(); >> } >> } --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg