All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Weil <sw@weilnetz.de>
To: "Justin M. Forbes" <jforbes@redhat.com>
Cc: Kenneth Salerno <kennethsalerno@yahoo.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [patch] qemu-1.0.1/VERSION
Date: Sun, 19 Feb 2012 11:51:25 +0100	[thread overview]
Message-ID: <4F40D42D.4020608@weilnetz.de> (raw)
In-Reply-To: <1329609944.90569.YahooMailClassic@web110415.mail.gq1.yahoo.com>

Am 19.02.2012 01:05, schrieb Kenneth Salerno:
> Hello,
>
> The VERSION file in stable release qemu-1.0.1 has what I believe might be a typo: "1.0,1" rather than "1.0.1". This is causing a parsing issue for windres.exe in Win32 which chokes on:
>     #define CONFIG_FILEVERSION 1,0,1,0,1,0
>     #define CONFIG_PRODUCTVERSION 1,0,1,0,1,0
>
> when it should be seeing this:
>     #define CONFIG_FILEVERSION 1,0,1,0
>     #define CONFIG_PRODUCTVERSION 1,0,1,0
>
>
> Patch:
> --- VERSION.ORIG        2012-02-18 18:56:16.625000000 -0500
> +++ VERSION     2012-02-18 18:56:31.609375000 -0500
> @@ -1 +1 @@
> -1.0,1
> +1.0.1

Acked-by: Stefan Weil <sw@weilnetz.de>

  reply	other threads:[~2012-02-19 10:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-19  0:05 [Qemu-devel] [patch] qemu-1.0.1/VERSION Kenneth Salerno
2012-02-19 10:51 ` Stefan Weil [this message]
2012-02-19 22:26   ` Justin M. Forbes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F40D42D.4020608@weilnetz.de \
    --to=sw@weilnetz.de \
    --cc=jforbes@redhat.com \
    --cc=kennethsalerno@yahoo.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.