From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:48319)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Rz8sf-000345-Qs
	for qemu-devel@nongnu.org; Sun, 19 Feb 2012 10:40:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Rz8se-0005Rb-TB
	for qemu-devel@nongnu.org; Sun, 19 Feb 2012 10:40:53 -0500
Message-ID: <4F4117FF.5090600@suse.de>
Date: Sun, 19 Feb 2012 16:40:47 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1329664586-13923-1-git-send-email-zwu.kernel@gmail.com>
In-Reply-To: <1329664586-13923-1-git-send-email-zwu.kernel@gmail.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] block: fix block I/O throtting with IDE
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: zwu.kernel@gmail.com
Cc: Kevin Wolf <kwolf@redhat.com>, chris@arachsys.com, stefanha@linux.vnet.ibm.com, qemu-devel@nongnu.org, qemu-stable@nongnu.org, Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>

Am 19.02.2012 16:16, schrieb zwu.kernel@gmail.com:
> From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
>=20
> The patch is based on the latest QEMU upstream. If you will backport th=
e patchset to QEMU 1.0, pls note the difference.

"Fix" is never a good patch description. ;) In place of the above
sentence, which does not tell us what the actual difference is, please
describe in which way it was broken before and what the patch changes.

And if this is to be fixed on stable-1.0, please cc qemu-stable.

Andreas

>=20
> Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
> ---
>  block.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
>=20
> diff --git a/block.c b/block.c
> index ae297bb..07cd143 100644
> --- a/block.c
> +++ b/block.c
> @@ -863,6 +863,12 @@ void bdrv_drain_all(void)
>  {
>      BlockDriverState *bs;
> =20
> +    QTAILQ_FOREACH(bs, &bdrv_states, list) {
> +        if (!qemu_co_queue_empty(&bs->throttled_reqs)) {
> +            qemu_co_queue_restart_all(&bs->throttled_reqs);
> +        }
> +    }
> +
>      qemu_aio_flush();
> =20
>      /* If requests are still pending there is a bug somewhere */

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg