All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Rankin <rankincj@yahoo.com>
To: gennarone@gmail.com, linux-media@vger.kernel.org
Subject: [PATCH] em28xx: pre-allocate DVB isoc transfer buffers
Date: Sun, 19 Feb 2012 23:46:51 +0000	[thread overview]
Message-ID: <4F4189EB.6020202@yahoo.com> (raw)
In-Reply-To: <1329155962-22896-1-git-send-email-gennarone@gmail.com>

Gianluca,

One quick comment about your patch; I've noticed that you've declared two new 
"GPL only" symbols:

EXPORT_SYMBOL_GPL(em28xx_capture_start);
EXPORT_SYMBOL_GPL(em28xx_alloc_isoc);

I'm not sure what the exact policy is with GPL symbols, but I do know what Al 
Viro posted recently on the subject:

http://thread.gmane.org/gmane.linux.file-systems/61372

Do we really need EXPORT_SYMBOL_GPL() here?

Cheers,
Chris

  reply	other threads:[~2012-02-19 23:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-13 17:59 [PATCH] em28xx: pre-allocate DVB isoc transfer buffers Gianluca Gennari
2012-02-19 23:46 ` Chris Rankin [this message]
2012-02-20  0:18   ` Gianluca Gennari
2012-03-16  0:25 ` Andy Furniss
2012-03-16  1:38   ` Gianluca Gennari
2012-03-16  1:38   ` Gianluca Gennari
2012-03-16 10:16     ` Andy Furniss
2012-03-16 15:05       ` Andy Furniss
2012-03-16 15:39         ` Gianluca Gennari
2012-03-16 15:51           ` Andy Furniss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F4189EB.6020202@yahoo.com \
    --to=rankincj@yahoo.com \
    --cc=gennarone@gmail.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.