From: Daniel Gorsulowski <Daniel.Gorsulowski@esd.eu>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] at91: modified NAND flash timing on meesc board
Date: Mon, 20 Feb 2012 07:01:52 +0100 [thread overview]
Message-ID: <4F41E1D0.3090104@esd.eu> (raw)
In-Reply-To: <4F3F92BE.6070300@aribaud.net>
Hi Albert,
Albert ARIBAUD wrote:
> Hi Daniel,
>
> Le 25/01/2012 14:19, Daniel Gorsulowski a ?crit :
>> Signed-off-by: Daniel Gorsulowski<Daniel.Gorsulowski@esd.eu>
>> ---
>> board/esd/meesc/meesc.c | 8 ++++----
>> 1 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/board/esd/meesc/meesc.c b/board/esd/meesc/meesc.c
>> index 4882ffc..9dd4375 100644
>> --- a/board/esd/meesc/meesc.c
>> +++ b/board/esd/meesc/meesc.c
>> @@ -73,20 +73,20 @@ static void meesc_nand_hw_init(void)
>> writel(csa,&matrix->csa[0]);
>>
>> /* Configure SMC CS3 for NAND/SmartMedia */
>> - writel(AT91_SMC_SETUP_NWE(1) | AT91_SMC_SETUP_NCS_WR(0) |
>> - AT91_SMC_SETUP_NRD(1) | AT91_SMC_SETUP_NCS_RD(0),
>> + writel(AT91_SMC_SETUP_NWE(1) | AT91_SMC_SETUP_NCS_WR(1) |
>> + AT91_SMC_SETUP_NRD(2) | AT91_SMC_SETUP_NCS_RD(2),
>> &smc->cs[3].setup);
>>
>> writel(AT91_SMC_PULSE_NWE(3) | AT91_SMC_PULSE_NCS_WR(3) |
>> AT91_SMC_PULSE_NRD(3) | AT91_SMC_PULSE_NCS_RD(3),
>> &smc->cs[3].pulse);
>>
>> - writel(AT91_SMC_CYCLE_NWE(5) | AT91_SMC_CYCLE_NRD(5),
>> + writel(AT91_SMC_CYCLE_NWE(6) | AT91_SMC_CYCLE_NRD(6),
>> &smc->cs[3].cycle);
>> writel(AT91_SMC_MODE_RM_NRD | AT91_SMC_MODE_WM_NWE |
>> AT91_SMC_MODE_EXNW_DISABLE |
>> AT91_SMC_MODE_DBW_8 |
>> - AT91_SMC_MODE_TDF_CYCLE(3),
>> + AT91_SMC_MODE_TDF_CYCLE(12),
>> &smc->cs[3].mode);
>>
>> /* Configure RDY/BSY */
>
> Is this (and its counterpart for otc570) a performance improvement or a
> bug fix?.
There were problems with a new batch of NAND flashes in our production
process. We figured out, that the NAND timing is too fast.
So I would call this a bug fix.
>
> Amicalement,
> --
> Albert.
Kind regards,
Daniel Gorsulowski
next prev parent reply other threads:[~2012-02-20 6:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-25 13:19 [U-Boot] [PATCH 1/2] at91: modified NAND flash timing on meesc board Daniel Gorsulowski
2012-02-18 11:59 ` Albert ARIBAUD
2012-02-20 6:01 ` Daniel Gorsulowski [this message]
2012-02-20 8:01 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F41E1D0.3090104@esd.eu \
--to=daniel.gorsulowski@esd.eu \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.