From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v2 2/4] RTC:Add RTC update-ended interrupt logic Date: Mon, 20 Feb 2012 08:38:20 +0100 Message-ID: <4F41F86C.8010801@redhat.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "qemu-devel@nongnu.org" , Jan Kiszka , "kvm@vger.kernel.org" , "aliguori@us.ibm.com" , Marcelo Tosatti To: "Zhang, Yang Z" Return-path: Received: from mail-ey0-f174.google.com ([209.85.215.174]:32948 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750720Ab2BTHiX (ORCPT ); Mon, 20 Feb 2012 02:38:23 -0500 Received: by eaah12 with SMTP id h12so2077051eaa.19 for ; Sun, 19 Feb 2012 23:38:22 -0800 (PST) In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 02/20/2012 01:25 AM, Zhang, Yang Z wrote: > Use timer to emulate RTC update-ended interrupt. The timer is enabled > only when UIE is setting. The timer needs to be enabled when UF is clear, not when UIE is set. If UIE is set but the update interrupt is masked you do not need to do anything; on the other hand you need to update UF in case the guest is observing interrupts with polling. Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:58413) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RzNpO-0007Ax-2w for qemu-devel@nongnu.org; Mon, 20 Feb 2012 02:38:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RzNpI-0001XZ-4E for qemu-devel@nongnu.org; Mon, 20 Feb 2012 02:38:30 -0500 Received: from mail-ey0-f173.google.com ([209.85.215.173]:36438) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RzNpH-0001XU-W1 for qemu-devel@nongnu.org; Mon, 20 Feb 2012 02:38:24 -0500 Received: by eaac1 with SMTP id c1so2288826eaa.4 for ; Sun, 19 Feb 2012 23:38:22 -0800 (PST) Sender: Paolo Bonzini Message-ID: <4F41F86C.8010801@redhat.com> Date: Mon, 20 Feb 2012 08:38:20 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 2/4] RTC:Add RTC update-ended interrupt logic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Zhang, Yang Z" Cc: "aliguori@us.ibm.com" , Marcelo Tosatti , Jan Kiszka , "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" On 02/20/2012 01:25 AM, Zhang, Yang Z wrote: > Use timer to emulate RTC update-ended interrupt. The timer is enabled > only when UIE is setting. The timer needs to be enabled when UF is clear, not when UIE is set. If UIE is set but the update interrupt is masked you do not need to do anything; on the other hand you need to update UF in case the guest is observing interrupts with polling. Paolo