From: Jens Axboe <axboe@kernel.dk>
To: Josh Carter <public@joshcarter.com>
Cc: fio@vger.kernel.org, "Bill Hooper (whooper)" <whooper@micron.com>
Subject: Re: Formats for log files
Date: Mon, 20 Feb 2012 10:08:21 +0100 [thread overview]
Message-ID: <4F420D85.1090803@kernel.dk> (raw)
In-Reply-To: <EF8C77A9-96EC-42F3-BC18-535FDDD9B0DF@joshcarter.com>
On 02/16/2012 08:46 PM, Josh Carter wrote:
> Hi Bill,
>
> Looking at the code, I believe you're correct, the bandwidth logging
> for mixed loads isn't right. While read and write logs are kept
> separate, only one direction's log will get flushed on each interval.
> Instead, fio should flush both directions.
>
> I'm attaching a patch. Jens: could you take a look at this? I've
> tested both mixed and single-direction workloads, seems to work fine.
Patch looks good, applied. Thanks!
--
Jens Axboe
next prev parent reply other threads:[~2012-02-20 9:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-15 21:42 Formats for log files Bill Hooper (whooper)
2012-02-16 1:26 ` Josh Carter
2012-02-16 17:33 ` Bill Hooper (whooper)
[not found] ` <B53FFA03-CFB4-46BB-882A-602F045FAF24@joshcarter.com>
[not found] ` <8C39003C166535489D52AF2C9D8C58BC1A316DBD@NTXBOIMBX04.micron.com>
2012-02-16 19:46 ` Josh Carter
2012-02-20 9:08 ` Jens Axboe [this message]
2012-02-20 17:17 ` Bill Hooper (whooper)
2012-02-20 18:57 ` Jens Axboe
2012-02-20 19:20 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F420D85.1090803@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=public@joshcarter.com \
--cc=whooper@micron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.