From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] UBIFS: Improve error message when reading superblock failed
Date: Mon, 20 Feb 2012 11:01:24 +0100 [thread overview]
Message-ID: <4F4219F4.3080005@aribaud.net> (raw)
In-Reply-To: <4F420E33.3000002@corscience.de>
Hi Bernhard,
Le 20/02/2012 10:11, Bernhard Walle a ?crit :
> Am 20.02.2012 09:59, schrieb Albert ARIBAUD:
>>
>> Dry numbers as error messages are better than no error messages but only
>> marginally IMO. Isn't there a way to emit a readable message re malloc
>> instead of emitting an int value?
>
> Well, I'm not familiar with the u-boot codebase. Does u-boot have a
> strerror table? How is it handled on other places? Should an error
> message printed directly before returning -ENOMEM?
I don't think there is an strerror() API. But at least, if the newly
printed int uses errno values, then instead of '... %d!", you could
print "... errno=%d", which would give some hint to the reader.
> Regards,
> Bernhard
Amicalement,
--
Albert.
next prev parent reply other threads:[~2012-02-20 10:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-09 17:15 [U-Boot] [PATCH] UBIFS: Improve error message when reading superblock failed Bernhard Walle
2012-02-17 14:15 ` Detlev Zundel
2012-02-17 14:31 ` Bernhard Walle
2012-02-17 15:00 ` Detlev Zundel
2012-02-20 8:44 ` Bernhard Walle
2012-02-20 8:59 ` Albert ARIBAUD
2012-02-20 9:11 ` Bernhard Walle
2012-02-20 10:01 ` Albert ARIBAUD [this message]
2012-04-02 11:58 ` Thomas Weber
2012-05-15 20:33 ` Thomas Weber
2012-08-09 20:12 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4219F4.3080005@aribaud.net \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.