Re: [Qemu-devel] [PATCH v2 1/1] exec: Fix watchpoint implementation

[Meador Inge <meadori@codesourcery.com>]

On 02/18/2012 10:33 AM, Andreas Färber wrote:

> Am 17.02.2012 18:06, schrieb Andreas Färber:
>> Am 17.02.2012 18:03, schrieb Meador Inge:
>>> Fix a bug introduced by commit 1ec9b909ff207a44d5ef2609cb4a2e3d449d485f
>>> where 'watch_mem_write' was modified to fall-through to 'abort' on
>>> every input.
>>>
>>> Signed-off-by: Meador Inge <meadori@codesourcery.com>
>>
>> Reviewed-by: Andreas Färber <afaerber@suse.de>
> 
> Actually I already reviewed such a fix by Max on Jan 29 (with breaks
> from the start), and it's in his PULL request now. So this is again a
> duplicate and shouldn't be applied.
> 
> If you want to remind maintainers of a patch that's been on the list but
> has not yet been applied, the correct procedure is to add a Reviewed-by
> or Acked-by tag if you haven't already, or to reply with a "Ping?"
> otherwise.

Ah, I missed that.  I will add a review tag to the other.  Thanks for the heads
up.

-- 
Meador Inge
CodeSourcery / Mentor Embedded
http://www.mentor.com/embedded-software