Re: [Qemu-devel] [PATCH 1/6] console: allow VCs to be overridden by UI

[Anthony Liguori <anthony@codemonkey.ws>]

On 02/20/2012 08:27 AM, Gerd Hoffmann wrote:
>    Hi,
>
>> This would require touching a fair bit of code that handles things like
>> defaults.  I'm not sure that having the distinction makes anything
>> easier to implement.
>
> /me suggests to simply have no default terminals with qemu -gtk.
>
>> One thing I was contemplating but ultimately didn't do was QOM-ification
>> of the GTK front end.  I couldn't rationalize why you would need to set
>> settings but now I think maybe it would be more useful.
>
> With a vte chardev you have an object you can attach settings to, i.e.
> -chardev vte,mode={tab,window}.

Right, but you could do the same with QOM, it would look like:

GtkDisplay is-a UserInterface (maybe?)
   has-a GtkVirtualConsole "vc0"
   has-a GtkVirtualConsole "vc1"
   ...

GtkVirtualConsole could have a "mode" property.


So from a UI perspective, you would do something like:

-gtk -set /ui/vc0.mode=tab

I think it makes more sense overall as a sub-property of the main ui object 
verses a property of a character device (which is only tangentially related to 
the UI itself).

Regards,

Anthony Liguori

>
> cheers,
>    Gerd
>
>