All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@xenotime.net>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Theodore Ts'o <tytso@mit.edu>, linux-next@vger.kernel.org
Subject: Re: [PATCH -next] ext4: get rid of compile warning
Date: Mon, 20 Feb 2012 08:00:05 -0800	[thread overview]
Message-ID: <4F426E05.1000600@xenotime.net> (raw)
In-Reply-To: <20120220125655.GA2651@osiris.boeblingen.de.ibm.com>

On 02/20/2012 04:56 AM, Heiko Carstens wrote:
> Get rid of this one:
>
> fs/ext4/balloc.c: In function 'ext4_wait_block_bitmap':
> fs/ext4/balloc.c:405:3: warning: format '%llu' expects argument of
>    type 'long long unsigned int', but argument 6 has type 'sector_t' [-Wformat]
>
> Happens because sector_t is u64 (unsigned long long) or unsigned long
> dependent on CONFIG_64BIT.
>
> Signed-off-by: Heiko Carstens<heiko.carstens@de.ibm.com>

I sent the same patch on Jan. 30.  I wonder what happened to it?

Acked-by: Randy Dunlap <rdunlap@xenotime.net>

Thanks.

> ---
>   fs/ext4/balloc.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/ext4/balloc.c b/fs/ext4/balloc.c
> index 95c87ab..c355890 100644
> --- a/fs/ext4/balloc.c
> +++ b/fs/ext4/balloc.c
> @@ -404,7 +404,7 @@ int ext4_wait_block_bitmap(struct super_block *sb, ext4_group_t block_group,
>   	if (!buffer_uptodate(bh)) {
>   		ext4_error(sb, "Cannot read block bitmap - "
>   			   "block_group = %u, block_bitmap = %llu",
> -			   block_group, bh->b_blocknr);
> +			   block_group, (unsigned long long) bh->b_blocknr);
>   		return 1;
>   	}
>   	/* Panic or remount fs read-only if block bitmap is invalid */


-- 
~Randy

  reply	other threads:[~2012-02-20 16:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-20 12:56 [PATCH -next] ext4: get rid of compile warning Heiko Carstens
2012-02-20 16:00 ` Randy Dunlap [this message]
2012-02-21  3:13   ` Ted Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F426E05.1000600@xenotime.net \
    --to=rdunlap@xenotime.net \
    --cc=heiko.carstens@de.ibm.com \
    --cc=linux-next@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.