From: Clemens Ladisch <clemens@ladisch.de>
To: Mark Hills <mark@pogo.org.uk>
Cc: alsa-devel@alsa-project.org, Daniel Mack <zonque@gmail.com>
Subject: Re: usb-audio: Correct way to do a mixer quirk?
Date: Mon, 20 Feb 2012 22:40:25 +0100 [thread overview]
Message-ID: <4F42BDC9.4040605@ladisch.de> (raw)
In-Reply-To: <alpine.LNX.2.01.1202201945150.10992@stax.localdomain>
Mark Hills wrote:
> On Mon, 20 Feb 2012, Clemens Ladisch wrote:
>> Mark Hills wrote:
>>> The Electrix Ebox-44 is a new USB interface, but the MIXER_UNIT descriptor
>>> is broken and refers to a non-existing unit_id.
>>
>> I'd suggest to change the code to not abort if a unit doesn't exist.
>
> It would seem a little strange to skip over the error for one specific
> condition to accomodate a specific device -- when the rest of the code
> does not generally do this?
It's still possible to complain about the broken firmware, but there is
no reason to prevent the user from accessing the PCM streams and all
other mixer controls just because one descriptors happens to be wrong.
Regards,
Clemens
next prev parent reply other threads:[~2012-02-20 21:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-19 21:49 usb-audio: Correct way to do a mixer quirk? Mark Hills
2012-02-20 8:07 ` Clemens Ladisch
2012-02-20 19:55 ` Mark Hills
2012-02-20 21:40 ` Clemens Ladisch [this message]
2012-02-24 12:26 ` Mark Hills
2012-03-09 12:13 ` Mark Hills
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F42BDC9.4040605@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=mark@pogo.org.uk \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.