From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kenneth Graunke <kenneth@whitecape.org>
Subject: Re: [PATCH 2/2] intel: Remove Ironlake from IS_GEN4
	macro.
Date: Tue, 21 Feb 2012 14:24:25 -0800
Message-ID: <4F441999.6040406@whitecape.org>
References: <1329857978-30626-1-git-send-email-kenneth@whitecape.org>
	<1329857978-30626-2-git-send-email-kenneth@whitecape.org>
	<e39f63$3pub8q@fmsmga002.fm.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from homiemail-a37.g.dreamhost.com (caiajhbdcbhh.dreamhost.com
	[208.97.132.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id 012F4A0D90
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 21 Feb 2012 14:24:32 -0800 (PST)
In-Reply-To: <e39f63$3pub8q@fmsmga002.fm.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On 02/21/2012 01:08 PM, Chris Wilson wrote:
> On Tue, 21 Feb 2012 12:59:38 -0800, Kenneth Graunke<kenneth@whitecape.org>  wrote:
>> Signed-off-by: Kenneth Graunke<kenneth@whitecape.org>
>
> A task for a rainy afternoon would be to rigorously use the verbose
> PCI_ID_* names rather than the raw values.
>
> Reviewed-by: Chris Wilson<chris@chris-wilson.co.uk>
>
>> ---
>>   intel/intel_chipset.h |    2 --
>>   1 files changed, 0 insertions(+), 2 deletions(-)
>>
>> diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h
>> index e3a30fc..1b6e357 100644
>> --- a/intel/intel_chipset.h
>> +++ b/intel/intel_chipset.h
>> @@ -96,8 +96,6 @@
>>   		      dev == 0x2E22 ||	\
>>   		      dev == 0x2E32 ||	\
>>   		      dev == 0x2E42 ||	\
> Note that these 5 IDs are part of IS_G4X, can you kill them as well (in
> another patch).
> -Chris

Hm.  I guess I consider G4X to be part of GEN4.  At least in Mesa, G4X 
is explicitly included:

#define IS_GEN4(devid) (devid == ... || ... || IS_G4X(devid))

Using that instead of hardcoding the IDs would be cleaner, though.