From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kenneth Graunke <kenneth@whitecape.org>
Subject: Re: [PATCH 1/2] intel: Add support for overriding the
 PCI ID via an environment variable
Date: Tue, 21 Feb 2012 14:42:37 -0800
Message-ID: <4F441DDD.5080405@whitecape.org>
References: <1329857978-30626-1-git-send-email-kenneth@whitecape.org>
	<e39f63$3pubsr@fmsmga002.fm.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from homiemail-a62.g.dreamhost.com (caiajhbdcbef.dreamhost.com
	[208.97.132.145])
	by gabe.freedesktop.org (Postfix) with ESMTP id 11A099EFF6
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 21 Feb 2012 14:42:40 -0800 (PST)
In-Reply-To: <e39f63$3pubsr@fmsmga002.fm.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On 02/21/2012 01:11 PM, Chris Wilson wrote:
> On Tue, 21 Feb 2012 12:59:37 -0800, Kenneth Graunke<kenneth@whitecape.org>  wrote:
>> @@ -1828,6 +1829,9 @@ drm_intel_gem_bo_mrb_exec2(drm_intel_bo *bo, int used,
>>   	execbuf.rsvd1 = 0;
>>   	execbuf.rsvd2 = 0;
>>
>> +	if (getenv("INTEL_DEVID_OVERRIDE"))
>> +		goto skip_execution;
>
> I'm not thrilled about calling getenv() for every execbuffer.

Good point.  I'll have to fix that.

> And what about the original execbuffer path?
> -Chris

Does anybody care?  I'm not even sure how I'd test it.

A little bit of background: this is a stepping stone on the way to 
simulator support.

When INTEL_DEVID_OVERRIDE is set, Mesa will generate code/batches for 
that system, rather than the current machine.  It also implicitly sets 
INTEL_NO_HW=1, which makes it avoid calling execbuf2.  This at least 
allows INTEL_DEBUG=vs,wm,bat style dumps, which is handy.

However, our .aub trace file support is in libdrm, so I need Mesa to 
execbuf, or I don't get aub file dumps.  But I don't want libdrm to 
-actually- exec it.