From: Tao Ma <tm@tao.ma>
To: Andreas Dilger <adilger@dilger.ca>
Cc: Ted Ts'o <tytso@mit.edu>,
ext4 development <linux-ext4@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH V4 00/22] ext4: Add inline data support
Date: Wed, 22 Feb 2012 09:34:46 +0800 [thread overview]
Message-ID: <4F444636.7070107@tao.ma> (raw)
In-Reply-To: <FA1EAF98-9D9C-408D-BB4C-4A116C6CEA19@dilger.ca>
On 02/22/2012 07:44 AM, Andreas Dilger wrote:
> On 2012-02-20, at 12:00 AM, Tao Ma wrote:
>> Hi Ted, Andreas and list,
>> This is the v4 attempt to add inline data support to ext4 inode.
>> For more information about the background, please refer to the thread
>> http://marc.info/?l=linux-ext4&m=131715205428067&w=2
>>
>> Changlog from v3 to v4:
>> 1. Add support for truncate which is really a bug.
>> 2. Some bug fixes.
>> 3. rebased to the latest kernel.
>
> I'm starting to look through this patch series, and a number of things are
Thanks for the review.
> missing that would make it much easier to understand and accept:
> - a good comment and possibly a diagram at the start of fs/ext4/xattr.c
> that describes where and how the inline data is stored in the inode,
> what the policies are for storing data inline or externally, etc.
sure, I will add it.
> - some benchmark data that shows why landing this code is desirable.
> My comments in the above thread show that small files and directories
> could benefit from this, but real proof now that you have made this
> patch is whether this translates into noticeable space savings, and
> hopefully also noticeable performance improvements in some benchmarks:
> - I suspect that running some tests with bigalloc + 512-byte inodes
> or similar could show significant space savings and speedups for
> cold-cache directory traversal
> - measuring boot time on a distro with Gnome or KDE could show real
> speedups due to the many small files and directories used at startup
> - running a benchmark like mongo or postmark with small files and
> with 256- or 512-byte inodes may also show real speedups
> - is there some workload that you are using that shows speedups that
> could be described in general terms and show relative performance,
> even if it is not possible to supply the actual benchmark/tests?
OK, I was just playing around with some bug fixes these days(to make it
stable in our production system) and doesn't do some performance tests
when upgrading from v2 to v3. I will try to do some tests and return the
data back in v5.
Thanks
Tao
>
> I'll go through the patches and suggest cleanups and improvements, but
> without improved documentation and real performance tests the patch is
> very unlikely to be accepted by Ted.
>
>> Changelog from v2 to v3:
>> 1. Add support for evict data from inode if we can store xattr in it.
>> 2. Add support for fiemap
>> 3. Some nasty bug fixes
>>
>> The v3 can be found here:
>> http://marc.info/?l=linux-ext4&m=132421821001634&w=2
>>
>> The v2 can be found here:
>> http://marc.info/?l=linux-ext4&m=132189338604177&w=2
>>
>> The v1 can be found here:
>> http://marc.info/?l=linux-ext4&m=131961438221255&w=2
>>
>> any suggestions are welcomed.
>>
>> Thanks
>> Tao
>
>
> Cheers, Andreas
>
>
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2012-02-22 1:34 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-20 7:00 [PATCH V4 00/22] ext4: Add inline data support Tao Ma
2012-02-20 7:01 ` [PATCH V4 01/22] ext4: Move extra inode read to a new function Tao Ma
2012-02-20 7:01 ` [PATCH V4 02/22] ext4: export inline xattr functions Tao Ma
2012-02-21 22:45 ` Andreas Dilger
2012-02-20 7:01 ` [PATCH V4 03/22] ext4: Add the basic function for inline data support Tao Ma
2012-04-07 0:21 ` Andreas Dilger
2012-04-13 2:59 ` Tao Ma
2012-02-20 7:01 ` [PATCH V4 04/22] ext4: Add read support for inline data Tao Ma
2012-02-20 7:01 ` [PATCH V4 05/22] ext4: Add normal write " Tao Ma
2012-02-20 7:01 ` [PATCH V4 06/22] ext4: Add journalled " Tao Ma
2012-02-20 7:01 ` [PATCH V4 07/22] ext4: Add delalloc " Tao Ma
2012-02-20 7:01 ` [PATCH V4 08/22] ext4: Create a new function ext4_init_new_dir Tao Ma
2012-02-20 7:01 ` [PATCH V4 09/22] ext4: Refactor __ext4_check_dir_entry to accepts start and size Tao Ma
2012-02-20 7:01 ` [PATCH V4 10/22] ext4: Create __ext4_insert_dentry for dir entry insertion Tao Ma
2012-02-20 7:01 ` [PATCH V4 11/22] ext4: let add_dir_entry handle inline data properly Tao Ma
2012-02-20 7:01 ` [PATCH V4 12/22] ext4: Let ext4_readdir handle inline data Tao Ma
2012-02-20 7:01 ` [PATCH V4 13/22] ext4: Create a new function search_dir Tao Ma
2012-02-20 7:01 ` [PATCH V4 14/22] ext4: let ext4_find_entry handle inline data Tao Ma
2012-02-20 7:01 ` [PATCH V4 15/22] ext4: make ext4_delete_entry generic Tao Ma
2012-02-20 7:01 ` [PATCH V4 16/22] ext4: let ext4_delete_entry handle inline data Tao Ma
2012-02-20 7:01 ` [PATCH V4 17/22] ext4: let empty_dir handle inline dir Tao Ma
2012-04-07 0:21 ` Andreas Dilger
2012-04-17 3:55 ` Tao Ma
2012-02-20 7:01 ` [PATCH V4 18/22] ext4: let ext4_rename " Tao Ma
2012-02-20 7:01 ` [PATCH V4 19/22] ext4: Let fiemap work with inline data Tao Ma
2012-02-20 7:01 ` [PATCH V4 20/22] ext4: Evict inline data out if we needs to strore xattr in inode Tao Ma
2012-02-20 7:01 ` [PATCH V4 21/22] ext4: let ext4_truncate handle inline data correctly Tao Ma
2012-02-20 7:01 ` [PATCH V4 22/22] ext4: Enable ext4 inline support Tao Ma
2012-02-21 6:51 ` [PATCH V4 01/22] ext4: Move extra inode read to a new function Andreas Dilger
2012-02-21 8:13 ` Tao Ma
2012-02-21 23:44 ` [PATCH V4 00/22] ext4: Add inline data support Andreas Dilger
2012-02-22 1:34 ` Tao Ma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F444636.7070107@tao.ma \
--to=tm@tao.ma \
--cc=adilger@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.