From: viresh.kumar@st.com (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm/spear600: fix one-shot timer
Date: Wed, 22 Feb 2012 10:00:03 +0530 [thread overview]
Message-ID: <4F446F4B.3030008@st.com> (raw)
In-Reply-To: <1329862755-7439-1-git-send-email-gilles.chanteperdrix@xenomai.org>
On 2/22/2012 3:49 AM, Gilles Chanteperdrix wrote:
> diff --git a/arch/arm/plat-spear/time.c b/arch/arm/plat-spear/time.c
> index 0c77e42..ac15ff3 100644
> --- a/arch/arm/plat-spear/time.c
> +++ b/arch/arm/plat-spear/time.c
> @@ -147,9 +147,12 @@ static int clockevent_next_event(unsigned long cycles,
> {
> u16 val;
>
> + val = readw(gpt_base + CR(CLKEVT));
can merge above three lines now.
> + if ((val & CTRL_ENABLE))
no need of extra (). Did you run checkpatch? I believe checkpatch
reports such issues.
> + writew(val & ~CTRL_ENABLE, gpt_base + CR(CLKEVT));
> +
> writew(cycles, gpt_base + LOAD(CLKEVT));
>
> - val = readw(gpt_base + CR(CLKEVT));
> val |= CTRL_ENABLE | CTRL_INT_ENABLE;
> writew(val, gpt_base + CR(CLKEVT));
Otherwise,
Acked-by: Viresh Kumar <viresh.kumar@st.com>
--
viresh
next prev parent reply other threads:[~2012-02-22 4:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-21 22:19 [PATCH] arm/spear600: fix one-shot timer Gilles Chanteperdrix
2012-02-22 4:30 ` Viresh Kumar [this message]
2012-02-22 10:18 ` [PATCH v2] " Gilles Chanteperdrix
2012-02-22 10:31 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F446F4B.3030008@st.com \
--to=viresh.kumar@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.