From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mitsyanko Igor Subject: Re: [Qemu-devel] KVM call agenda for tuesday 31 Date: Wed, 22 Feb 2012 12:06:35 +0400 Message-ID: <4F44A20B.2010506@samsung.com> References: <87ehuhrpel.fsf@elfo.elfo> <4F272A92.2010609@suse.de> <4F272D8C.8020608@codemonkey.ws> <4F27E98E.2080501@suse.de> Reply-To: i.mitsyanko@samsung.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7BIT Cc: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Anthony Liguori , quintela@redhat.com, Developers qemu-devel , KVM devel mailing list To: Peter Maydell Return-path: Received: from mailout1.w1.samsung.com ([210.118.77.11]:61775 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753440Ab2BVIGn (ORCPT ); Wed, 22 Feb 2012 03:06:43 -0500 Received: from euspt2 (mailout1.w1.samsung.com [210.118.77.11]) by mailout1.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTP id <0LZS0061TBV5HU@mailout1.w1.samsung.com> for kvm@vger.kernel.org; Wed, 22 Feb 2012 08:06:41 +0000 (GMT) Received: from [106.109.8.162] by spt2.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0LZS00LJRBV4C5@spt2.w1.samsung.com> for kvm@vger.kernel.org; Wed, 22 Feb 2012 08:06:41 +0000 (GMT) In-reply-to: Sender: kvm-owner@vger.kernel.org List-ID: On 02/21/2012 07:33 PM, Peter Maydell wrote: > Short summary: > * switch wp groups to bitfield rather than int array > * convert sd.c to use memory_region_init_ram() to allocate the wp groups > (being careful to use memory_region_set_dirty() when we touch them) > * we don't need variable-length fields for sd.c any more > * rest of the vmstate conversion is straightforward OK, got it. But it's not clear to me, have you decided against introducing .get_bufsize completely or just for sd.c? I still think it's a good idea and I wouldn't mind to use it in SD host controller implementation to retrieve buffer size directly from capabilities register, but I can take another approach for this of course. -- Mitsyanko Igor ASWG, Moscow R&D center, Samsung Electronics email: i.mitsyanko@samsung.com From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54489) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S07Dw-0000Xb-Hj for qemu-devel@nongnu.org; Wed, 22 Feb 2012 03:06:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S07Dq-00070O-46 for qemu-devel@nongnu.org; Wed, 22 Feb 2012 03:06:52 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:8967) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S07Dp-000709-Vx for qemu-devel@nongnu.org; Wed, 22 Feb 2012 03:06:46 -0500 MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; charset=UTF-8; format=flowed Received: from euspt2 ([210.118.77.14]) by mailout4.w1.samsung.com (Sun Java(tm) System Messaging Server 6.3-8.04 (built Jul 29 2009; 32bit)) with ESMTP id <0LZS001ERBV5BC50@mailout4.w1.samsung.com> for qemu-devel@nongnu.org; Wed, 22 Feb 2012 08:06:41 +0000 (GMT) Received: from [106.109.8.162] by spt2.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0LZS00LJRBV4C5@spt2.w1.samsung.com> for qemu-devel@nongnu.org; Wed, 22 Feb 2012 08:06:41 +0000 (GMT) Date: Wed, 22 Feb 2012 12:06:35 +0400 From: Mitsyanko Igor In-reply-to: Message-id: <4F44A20B.2010506@samsung.com> References: <87ehuhrpel.fsf@elfo.elfo> <4F272A92.2010609@suse.de> <4F272D8C.8020608@codemonkey.ws> <4F27E98E.2080501@suse.de> Subject: Re: [Qemu-devel] KVM call agenda for tuesday 31 Reply-To: i.mitsyanko@samsung.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Developers qemu-devel , KVM devel mailing list , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , quintela@redhat.com On 02/21/2012 07:33 PM, Peter Maydell wrote: > Short summary: > * switch wp groups to bitfield rather than int array > * convert sd.c to use memory_region_init_ram() to allocate the wp groups > (being careful to use memory_region_set_dirty() when we touch them) > * we don't need variable-length fields for sd.c any more > * rest of the vmstate conversion is straightforward OK, got it. But it's not clear to me, have you decided against introducing .get_bufsize completely or just for sd.c? I still think it's a good idea and I wouldn't mind to use it in SD host controller implementation to retrieve buffer size directly from capabilities register, but I can take another approach for this of course. -- Mitsyanko Igor ASWG, Moscow R&D center, Samsung Electronics email: i.mitsyanko@samsung.com