From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:42423) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S08Lh-00046W-Bm for qemu-devel@nongnu.org; Wed, 22 Feb 2012 04:18:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S08Lb-0002I8-NY for qemu-devel@nongnu.org; Wed, 22 Feb 2012 04:18:57 -0500 Received: from cantor2.suse.de ([195.135.220.15]:59584 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S08Lb-0002Ea-Gd for qemu-devel@nongnu.org; Wed, 22 Feb 2012 04:18:51 -0500 Message-ID: <4F44B2F9.1000204@suse.de> Date: Wed, 22 Feb 2012 10:18:49 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <20120222020705.GA10972@cs.nctu.edu.tw> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] Fix dependency issue introduced by commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?6Zmz6Z+L5Lu7?= Cc: Paolo Bonzini , qemu-devel@nongnu.org, Peter Maydell Am 22.02.2012 08:27, schrieb Paolo Bonzini: > On 02/22/2012 03:07 AM, =E9=99=B3=E9=9F=8B=E4=BB=BB wrote: >> =20 >> -HELPERS-$(CONFIG_LINUX) =3D qemu-bridge-helper$(EXESUF) >> +HELPERS-$(CONFIG_LINUX) : config-host.h qemu-bridge-helper$(EXESUF) >=20 > This is not declaring the dependency, it is declaring a target. >=20 > The rule should be like >=20 > qemu-bridge-helper.o: config-host.h ...which Peter has already done: http://patchwork.ozlabs.org/patch/142306/ Please coordinate with him. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg