From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:55037) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S08ts-0004en-Bm for qemu-devel@nongnu.org; Wed, 22 Feb 2012 04:54:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S08tm-0001Cm-NY for qemu-devel@nongnu.org; Wed, 22 Feb 2012 04:54:16 -0500 Received: from cantor2.suse.de ([195.135.220.15]:32843 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S08tm-0001Cc-DI for qemu-devel@nongnu.org; Wed, 22 Feb 2012 04:54:10 -0500 Message-ID: <4F44BB40.8070703@suse.de> Date: Wed, 22 Feb 2012 10:54:08 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1329706897-30476-1-git-send-email-david@gibson.dropbear.id.au> <8A3EA298-2301-454F-81AE-301E1D898F50@suse.de> <4F435747.2020304@redhat.com> <4F435F2D.3010007@redhat.com> <20120222011154.GN16796@truffala.fritz.box> In-Reply-To: <20120222011154.GN16796@truffala.fritz.box> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] Use DMADirection type for dma_bdrv_io List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , David Gibson Cc: Paolo Bonzini , Hannes Reinecke , Alexander Graf , qemu-devel@nongnu.org Am 22.02.2012 02:11, schrieb David Gibson: > On Tue, Feb 21, 2012 at 10:09:01AM +0100, Kevin Wolf wrote: >> Am 21.02.2012 09:35, schrieb Paolo Bonzini: >>> On 02/20/2012 11:50 AM, Alexander Graf wrote: >>>>>> DMAAIOCB *dbs =3D qemu_aio_get(&dma_aio_pool, bs, cb, opaque); >>>>>> >>>>>> - trace_dma_bdrv_io(dbs, bs, sector_num, to_dev); >>>>>> + trace_dma_bdrv_io(dbs, bs, sector_num, dir); >>>> Was the trace wrong before or is it now? I don't see its definition = changed anywhere. >>> >>> Not sure what you mean. :) >> >> trace-events: >> >> dma_bdrv_io(void *dbs, void *bs, int64_t sector_num, bool to_dev) >> "dbs=3D%p bs=3D%p sector_num=3D%" PRId64 " to_dev=3D%d" >=20 > Ah, damnit. Didn't find that file. I'll resubmit with trace-events > updated too. >=20 >> to_dev is declared bool here, and it should also be renamed to dir (th= e >> unfortunate thing about DMADirection is that it swaps 0 and 1 compared >> to bool to_dev... We need to check carefully that all occurrences have >> been caught.) >=20 > Yeah. And even more unfortunate that afaict there's no way to make > gcc warn on enum<->bool conversions. Still there are only about 4 > callers of dma_bdrv_io() - nearly everything uses the > dma_bdrv_{read,write}() wrappers - so I'm confident I got them all. Re all occurrences: megasas might be affected by such a change, too (patch on the list). Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg