From: Stanislav Kinsbursky <skinsbursky@parallels.com>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 2/2] NFS: Ensure struct nfs_client holds a reference to the net namespace
Date: Wed, 22 Feb 2012 16:51:04 +0400 [thread overview]
Message-ID: <4F44E4B8.4010405@parallels.com> (raw)
In-Reply-To: <1329637821-6986-2-git-send-email-Trond.Myklebust@netapp.com>
19.02.2012 11:50, Trond Myklebust пишет:
> Otherwise we have no guarantee that the net namespace won't just
> disappear from underneath us once the task that created it
> is destroyed.
I'm not 100% sure, but holding net reference on NFS client level looks redundant
to me, because nfs_client holds net reference on transport level (xprt_net).
But this is not an objection: code looks clearer and safer with this patch.
--
Best regards,
Stanislav Kinsbursky
prev parent reply other threads:[~2012-02-22 12:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-19 7:50 [PATCH 1/2] NFS: Ensure that the nfs_client 'net' field is always set Trond Myklebust
2012-02-19 7:50 ` [PATCH 2/2] NFS: Ensure struct nfs_client holds a reference to the net namespace Trond Myklebust
2012-02-22 12:51 ` Stanislav Kinsbursky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F44E4B8.4010405@parallels.com \
--to=skinsbursky@parallels.com \
--cc=Trond.Myklebust@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.