From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kukjin Kim Subject: Re: [PATCH 2/2] ARM: S3C24XX: Move the DMA base code to mach-s3c24xx Date: Thu, 23 Feb 2012 02:38:15 +0900 Message-ID: <4F452807.1090609@samsung.com> References: <201202212221.41744.heiko@sntech.de> <201202212226.57559.heiko@sntech.de> <201202221721.41262.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-pw0-f46.google.com ([209.85.160.46]:44153 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751995Ab2BVRiW (ORCPT ); Wed, 22 Feb 2012 12:38:22 -0500 Received: by pbcun15 with SMTP id un15so392728pbc.19 for ; Wed, 22 Feb 2012 09:38:22 -0800 (PST) In-Reply-To: <201202221721.41262.arnd@arndb.de> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, =?ISO-8859-1?Q?Heiko_St=FCbne?= =?ISO-8859-1?Q?r?= , Kukjin Kim , linux-samsung-soc@vger.kernel.org, 'Ben Dooks' , Vinod Koul , Dan Williams On 02/23/12 02:21, Arnd Bergmann wrote: > On Tuesday 21 February 2012, Heiko St=FCbner wrote: >> Signed-off-by: Heiko Stuebner >> --- >> arch/arm/mach-s3c24xx/Kconfig | 18 + >> arch/arm/mach-s3c24xx/Makefile | 1 + >> arch/arm/mach-s3c24xx/dma.c | 1469 ++++++++++++++++++++++++++++= ++++++++++++ >> arch/arm/plat-s3c24xx/Kconfig | 16 - >> arch/arm/plat-s3c24xx/Makefile | 1 - >> arch/arm/plat-s3c24xx/dma.c | 1469 ----------------------------= ------------ >> 6 files changed, 1488 insertions(+), 1486 deletions(-) >> create mode 100644 arch/arm/mach-s3c24xx/dma.c >> delete mode 100644 arch/arm/plat-s3c24xx/dma.c >> > > Wouldn't it be more appropriate to move this driver to > drivers/dma/s3c24xx-dma.c instead? > Basically I agree, it is just specific dma only for s3c24xx though. I think, for that, we need to update its driver when moving. > Even if it doesn't (yet) use the dmaengine API, I think it's > valuable to keep drivers with the same purpose together. We have > had similar discussions in other subsystems and ended up moving > the drivers into one directory first, followed by a conversion > to a common API (if someone could be motivated to do that work). > Yes, and we need to move s3c24xx cpufreq to drivers/cpufreq and it will= =20 be done soon. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. From mboxrd@z Thu Jan 1 00:00:00 1970 From: kgene.kim@samsung.com (Kukjin Kim) Date: Thu, 23 Feb 2012 02:38:15 +0900 Subject: [PATCH 2/2] ARM: S3C24XX: Move the DMA base code to mach-s3c24xx In-Reply-To: <201202221721.41262.arnd@arndb.de> References: <201202212221.41744.heiko@sntech.de> <201202212226.57559.heiko@sntech.de> <201202221721.41262.arnd@arndb.de> Message-ID: <4F452807.1090609@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/23/12 02:21, Arnd Bergmann wrote: > On Tuesday 21 February 2012, Heiko St?bner wrote: >> Signed-off-by: Heiko Stuebner >> --- >> arch/arm/mach-s3c24xx/Kconfig | 18 + >> arch/arm/mach-s3c24xx/Makefile | 1 + >> arch/arm/mach-s3c24xx/dma.c | 1469 ++++++++++++++++++++++++++++++++++++++++ >> arch/arm/plat-s3c24xx/Kconfig | 16 - >> arch/arm/plat-s3c24xx/Makefile | 1 - >> arch/arm/plat-s3c24xx/dma.c | 1469 ---------------------------------------- >> 6 files changed, 1488 insertions(+), 1486 deletions(-) >> create mode 100644 arch/arm/mach-s3c24xx/dma.c >> delete mode 100644 arch/arm/plat-s3c24xx/dma.c >> > > Wouldn't it be more appropriate to move this driver to > drivers/dma/s3c24xx-dma.c instead? > Basically I agree, it is just specific dma only for s3c24xx though. I think, for that, we need to update its driver when moving. > Even if it doesn't (yet) use the dmaengine API, I think it's > valuable to keep drivers with the same purpose together. We have > had similar discussions in other subsystems and ended up moving > the drivers into one directory first, followed by a conversion > to a common API (if someone could be motivated to do that work). > Yes, and we need to move s3c24xx cpufreq to drivers/cpufreq and it will be done soon. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.