From: Daniel Mack <zonque@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>,
Daniel Mack <daniel@caiaq.de>
Subject: Re: [PATCH 0/5] Refresh ak4104 driver
Date: Wed, 22 Feb 2012 19:48:02 +0100 [thread overview]
Message-ID: <4F453862.2050409@gmail.com> (raw)
In-Reply-To: <20120217202240.GA2784@opensource.wolfsonmicro.com>
On 17.02.2012 21:22, Mark Brown wrote:
> This patch series updates the ak4104 driver to more modern idioms,
> mainly converting to regmap. I've absolutely no ability to test this so
> there's a reasonable chance this will just explode but hopefully it
> should work fine. Since all the read modify write, I/O and cache code
> was open coded in the driver we end up factoring out a reasonable
> amount.
>
> Mark Brown (5):
> ASoC: ak4104: Remove uninformative print on probe()
> ASoC: ak4104: Convert to module_spi_driver()
> ASoC: ak4104: Use snd_soc_update_bits() for read/modify/write
> ASoC: ak4104: Use snd_soc_write() rather than internal write function
> ASoC: ak4104: Convert to direct regmap API usage
The changes look all fine, but I can't test them either at the moment.
Just take my Ack on them and bring them in the loop. If someone yells,
I'll fix up things :)
prev parent reply other threads:[~2012-02-22 18:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-17 20:22 [PATCH 0/5] Refresh ak4104 driver Mark Brown
2012-02-17 20:23 ` [PATCH 1/5] ASoC: ak4104: Remove uninformative print on probe() Mark Brown
2012-02-17 20:23 ` [PATCH 2/5] ASoC: ak4104: Convert to module_spi_driver() Mark Brown
2012-02-17 20:23 ` [PATCH 3/5] ASoC: ak4104: Use snd_soc_update_bits() for read/modify/write Mark Brown
2012-02-17 20:23 ` [PATCH 4/5] ASoC: ak4104: Use snd_soc_write() rather than internal write function Mark Brown
2012-02-17 20:23 ` [PATCH 5/5] ASoC: ak4104: Convert to direct regmap API usage Mark Brown
2012-02-22 18:48 ` Daniel Mack [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F453862.2050409@gmail.com \
--to=zonque@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=daniel@caiaq.de \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.