From: Richard Retanubun <richardretanubun-4VtgCsEi+FIybS5Ee8rs3A@public.gmane.org>
To: tomoya-linux-8lRStDepK8iSL1NxhRU65dBPR1lH4CV8@public.gmane.org,
ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org
Cc: "linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: eg20t i2c driver: missing some changes?
Date: Wed, 22 Feb 2012 14:46:02 -0500 [thread overview]
Message-ID: <4F4545FA.9050105@ruggedcom.com> (raw)
Hi
I am using i2c-eg20t on linux 3.1.6 and comparing with the current source on 3.3-rc4
I think there is a (few) missing cleanup between the version pasted on:
http://www.spinics.net/lists/linux-i2c/msg06664.html
to the one in version 3.3-rc4
one of it is this change in pch_i2c_getack
@@ -348,7 +347,7 @@
reg_val = ioread32(p + PCH_I2CSR) & PCH_GETACK;
if (reg_val != 0) {
- pch_err(adap, "return%d\n", -EPROTO);
+ pch_dbg(adap, "return%d\n", -EPROTO);
return -EPROTO;
}
Without this change, using i2cdetect will generate a lot of false positive errors on devices that are not present.
I'm not sure if there is a patch that is missed or still being reviewed that contained this change
There are also some other differences between the mailing list version and linux-3.3rc4 in addition to this one,
but I don't have enough background to comment on them.
--
Richard Retanubun
reply other threads:[~2012-02-22 19:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4545FA.9050105@ruggedcom.com \
--to=richardretanubun-4vtgcsei+fiybs5ee8rs3a@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tomoya-linux-8lRStDepK8iSL1NxhRU65dBPR1lH4CV8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.