All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arun Sharma <asharma@fb.com>
To: David Miller <davem@davemloft.net>
Cc: <ja@ssi.bg>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <shemminger@vyatta.com>
Subject: Re: route add default fails with ESRCH?
Date: Wed, 22 Feb 2012 17:26:26 -0800	[thread overview]
Message-ID: <4F4595C2.8000809@fb.com> (raw)
In-Reply-To: <20120222.185625.1452176745900047968.davem@davemloft.net>

On 2/22/12 3:56 PM, David Miller wrote:
>
> It breaks because that script sequence quoted above depends upon the
> order in which the routes are listed.  Since fib_hash and fib_trie use
> different datastructures, the order in which route entries are dumped
> will not be the same and this is completely unavoidable.

Here's a minimal repro case:

# ip route flush default
# route add default gw 192.168.143.2
SIOCADDRT: No such process

This fails for me on both 2.6.38 and 3.2.

I think the dependency we have is the actual format of the default route 
entry:

fib_hash:

# ip route
<bunch of routes>
throw default

fib_trie:

# ip route
default via 192.168.143.2 dev eth0  proto static
<bunch of routes>

when the output was piped to awk '{ print $1 }' we ended up deleting the 
default route for fib_trie case, but not the fib_hash case.

I'll just fix up our scripts. Thanks for looking into it.

  -Arun


  reply	other threads:[~2012-02-23  1:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-18  1:39 route add default fails with ESRCH? Arun Sharma
2012-02-22 19:28 ` Arun Sharma
2012-02-22 21:27   ` Julian Anastasov
2012-02-22 21:52     ` Arun Sharma
2012-02-22 23:03       ` Arun Sharma
2012-02-22 23:56         ` David Miller
2012-02-23  1:26           ` Arun Sharma [this message]
2012-02-23  0:02       ` Julian Anastasov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F4595C2.8000809@fb.com \
    --to=asharma@fb.com \
    --cc=davem@davemloft.net \
    --cc=ja@ssi.bg \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.