From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] OMAP4: dma: Correct CPU version check for dma_common_ch_end
Date: Thu, 23 Feb 2012 09:29:05 +0200 [thread overview]
Message-ID: <4F45EAC1.5070309@ti.com> (raw)
In-Reply-To: <20120222230714.GV18185@atomide.com>
Hi Tony,
On 02/23/2012 01:07 AM, Tony Lindgren wrote:
> * Peter Ujfalusi <peter.ujfalusi@ti.com> [120217 00:54]:
>> CCDN is the last common channel register in all OMAP4 versions. Use
>> cpu_is_omap44xx() instead of the cpu_is_omap4430() - which is anyway not
>> doing what it supposed to do.
>
> This is a bit unclear.. Which is not doing what is supposed to do?
> DMA driver? Or one of the cpu_is_omap?
The cpu_is_omap4430() returns 0 unconditionally. Because of this the
dma_common_ch_end is wrongly configured on OMAP4 (even on OMAP4430).
> If this should be queued as a fix, then we need some kind of
> description here what breaks.
I will resend the patch with a better commit message. This is a bug for
sure, but I'm not sure how severe it is. At best we are not clearing the
registers between CCFN, and CCDN on OMAP4.
--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-02-23 7:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-17 9:25 [PATCH] OMAP4: dma: Correct CPU version check for dma_common_ch_end Peter Ujfalusi
2012-02-22 23:07 ` Tony Lindgren
2012-02-23 7:29 ` Peter Ujfalusi [this message]
2012-02-23 8:42 ` Shilimkar, Santosh
2012-02-23 9:04 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F45EAC1.5070309@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.