From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: NeilBrown <neilb@suse.de>
Cc: meyering@redhat.com, linux-raid@vger.kernel.org
Subject: Re: [PATCH] Print error message if failing to write super for 1.x metadata
Date: Thu, 23 Feb 2012 09:41:54 +0100 [thread overview]
Message-ID: <4F45FBD2.80004@redhat.com> (raw)
In-Reply-To: <20120223085802.57586d60@notabene.brown>
On 02/22/12 22:58, NeilBrown wrote:
> On Wed, 22 Feb 2012 12:01:56 +0100 Jes.Sorensen@redhat.com wrote:
>
>> > From: Jes Sorensen <Jes.Sorensen@redhat.com>
>> >
>> > In addition remove attempt to print an error message if
>> > write_init_super() fails, as this is handled in the various
>> > write_init_super() functions. This avoids a segfault on error.
>> >
>> > Reported by Jim Meyering in
>> > https://bugzilla.redhat.com/show_bug.cgi?id=795461
>> >
>> > Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
> Applied, thanks.
>
> Though there was already a case which printed an error which you left
> unchanged so now in some cases it would print the same message twice.
> So I removed the old printf.
Whoops, thanks for catching that.
Cheers,
Jes
prev parent reply other threads:[~2012-02-23 8:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-22 11:01 [PATCH] Print error message if failing to write super for 1.x metadata Jes.Sorensen
2012-02-22 21:58 ` NeilBrown
2012-02-23 8:41 ` Jes Sorensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F45FBD2.80004@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=linux-raid@vger.kernel.org \
--cc=meyering@redhat.com \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.