From: Sebastian Schuberth <sschuberth@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Beat Bolli <bbolli@ewanet.ch>,
git@vger.kernel.org, Eric Raible <raible@nextest.com>
Subject: Re: [PATCH] cherry-pick -x: always insert an empty line
Date: Thu, 23 Feb 2012 10:38:14 +0100 [thread overview]
Message-ID: <4F460906.8030609@gmail.com> (raw)
In-Reply-To: <7vhaynp605.fsf@alter.siamese.dyndns.org>
On 19.02.2012 09:44, Junio C Hamano wrote:
> If we cherry pick your commit somewhere else with "-x -s", the resulting
> commit log message would end like this:
>
> Aside from that, even with a non-trivial commit the generated note
> "(cherry picked from commit 555c9864971744abb558796aea28e12a1ac20839)"
> seems abrupt when appended directly.
>
> Cc: Eric Raible<raible@nextest.com>
> Signed-off-by: Beat Bolli<bbolli@ewanet.ch>
>
> (cherry picked from commit 555c9864971744abb558796aea28e12a1ac20839)
> Signed-off-by: Frotz Xyzzy<nitfol@example.xz>
>
> which clearly is worse-looking with the extra LF you added in this patch.
Clearly? I would not say so, on the contrary. When using -s together
with -x, I'd interpret this as signing off the process of cherry-picking
itself, and as such, visually grouping the additional "signed-off" with
the "cherry picked from" makes sense to me.
--
Sebastian Schuberth
next prev parent reply other threads:[~2012-02-23 9:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-18 21:14 [PATCH] cherry-pick -x: always insert an empty line Beat Bolli
2012-02-19 8:44 ` Junio C Hamano
2012-02-23 8:39 ` Beat Bolli
2012-02-23 9:38 ` Sebastian Schuberth [this message]
2012-02-23 8:56 ` Sebastian Schuberth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F460906.8030609@gmail.com \
--to=sschuberth@gmail.com \
--cc=bbolli@ewanet.ch \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=raible@nextest.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.