All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Watts <rrw@kynesim.co.uk>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Kevin Hilman <khilman@ti.com>,
	linux-omap <linux-omap@vger.kernel.org>,
	balbi@ti.com
Subject: Re: help: BeagleBoard xM RevC ethernet port
Date: Thu, 23 Feb 2012 10:23:51 +0000	[thread overview]
Message-ID: <4F4613B7.8010601@kynesim.co.uk> (raw)
In-Reply-To: <874nuizfyf.fsf@ti.com>

On 22/02/12 22:00, Kevin Hilman wrote:
> Peter Ujfalusi <peter.ujfalusi@ti.com> writes:
> 
>> Hi,
>>
>> I hoped that time will solve this, but so far no luck. I just can not
>> get the ethernet port (along with the USB host ports) working on my xM RevC.
>> What is the trick to get it working on 3.3-rc3?
>>
>> There seams to be some configuration issue:
>>
>> [    1.437530] ehci_hcd: USB 2.0 'Enhanced' Host Controller (EHCI) Driver
>> [    1.444671] ehci_hcd: block sizes: qh 64 qtd 96 itd 160 sitd 96
>> [    1.451354] ehci-omap ehci-omap.0: failed to get ehci port0 regulator
>> [    1.458282] ehci-omap ehci-omap.0: failed to get ehci port1 regulator
> 
> 
> The first thing I try when I see these regulator failures is to add
> CONFIG_REGULATOR_DUMMY=y to the .config to see if that helps.  If so,
> then the board file needs some help configuring the right regulators.
> 
> Kevin
> --

 Apologies for the malformed patch, but I don't have time to clean it up
this morning (or test it in its cleaned state); however, the following
fixes the problem for me.

 It used to be masked because u-boot turns the regulator on to activate
ethernet on Beagle xM and no-one ever turns it off again, but some versions
of u-boot don't identify xM rev C correctly, so never turn it on ..

 Anyway, it's neater for the kernel to know what it's doing. And removes
a whole two lines of kernel startup output :-)


Richard.
---
commit 39d26ad563023acdddd06e8aaaf154378c373187
Author: Richard Watts <rrw@kynesim.co.uk>
Date:   Fri Jan 20 12:27:59 2012 +0000

    Turn on the USB regulator on Beagle xM explicitly, when the USB
    subsystem asks for it, rather than relying on u-boot to do it.

diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
index 4a71cb7..69ed6a0 100644
--- a/arch/arm/mach-omap2/board-omap3beagle.c
+++ b/arch/arm/mach-omap2/board-omap3beagle.c
@@ -362,11 +362,32 @@ static struct regulator_init_data beagle_vsim = {
 	.consumer_supplies	= beagle_vsim_supply,
 };

+static struct regulator_consumer_supply beagle_usb_supply[] = {
+    REGULATOR_SUPPLY("hsusb0", "ehci-omap.0"),
+    REGULATOR_SUPPLY("hsusb1", "ehci-omap.0")
+};
+
+static struct regulator_init_data usb_power = {
+    .constraints = {
+        .min_uV = 1800000,
+        .max_uV = 1800000,
+        .valid_modes_mask = REGULATOR_MODE_NORMAL,
+        .valid_ops_mask = REGULATOR_CHANGE_VOLTAGE
+        | REGULATOR_CHANGE_MODE
+        | REGULATOR_CHANGE_STATUS,
+    },
+    .num_consumer_supplies = ARRAY_SIZE(beagle_usb_supply),
+    .consumer_supplies = beagle_usb_supply
+};
+
+
+
 static struct twl4030_platform_data beagle_twldata = {
 	/* platform_data for children goes here */
 	.gpio		= &beagle_gpio_data,
 	.vmmc1		= &beagle_vmmc1,
 	.vsim		= &beagle_vsim,
+        .vaux2          = &usb_power,
 };

 static struct i2c_board_info __initdata beagle_i2c_eeprom[] =


  reply	other threads:[~2012-02-23 10:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-17  8:24 help: BeagleBoard xM RevC ethernet port Peter Ujfalusi
2012-02-22 22:00 ` Kevin Hilman
2012-02-23 10:23   ` Richard Watts [this message]
2012-02-27 14:32     ` Peter Ujfalusi
2012-02-28 14:04       ` Govindraj
2012-02-28 15:37         ` Robert Nelson
2012-02-29 18:06           ` Brian Austin
2012-03-01  7:22             ` Govindraj
2012-03-07 20:48               ` Brian Austin
2012-03-07 20:56                 ` Brian Austin
2012-03-08  6:13                   ` Govindraj
2012-03-05  9:52         ` Peter Ujfalusi
2012-03-05 18:28           ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F4613B7.8010601@kynesim.co.uk \
    --to=rrw@kynesim.co.uk \
    --cc=balbi@ti.com \
    --cc=khilman@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=peter.ujfalusi@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.