Re: [PATCH 2/2] Input/spear-keyboard: Provide thaw and poweroff routines

[Shubhrajyoti <shubhrajyoti@ti.com>]

On Thursday 23 February 2012 03:10 PM, Viresh Kumar wrote:
> Thaw and poweroff routines are missing for spear-keyboard. They are required for:
> - Error case scenarios during freeze
> - Using test features, of hibernate.
Not a comment doubt

When is thaw called and when is power off called?
> Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
> Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
> ---
>  drivers/input/keyboard/spear-keyboard.c |    5 +----
>  1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/input/keyboard/spear-keyboard.c b/drivers/input/keyboard/spear-keyboard.c
> index 6eb2dd8..6e83828 100644
> --- a/drivers/input/keyboard/spear-keyboard.c
> +++ b/drivers/input/keyboard/spear-keyboard.c
> @@ -321,10 +321,7 @@ static int spear_kbd_resume(struct device *dev)
>  	return 0;
>  }
>  
> -static const struct dev_pm_ops spear_kbd_pm_ops = {
> -	.suspend	= spear_kbd_suspend,
> -	.resume		= spear_kbd_resume,
> -};
Now that you have converted to simple dev pm can you remove the #ifdef
from pm.

> +static SIMPLE_DEV_PM_OPS(spear_kbd_pm_ops, spear_kbd_suspend, spear_kbd_resume);
>  #endif
>  
>  static struct platform_driver spear_kbd_driver = {