All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Simek <monstr@monstr.eu>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 8/8] microblaze: ll_temac: export xilinx_ll_temac_eth_init() for evaluation
Date: Thu, 23 Feb 2012 12:56:14 +0100	[thread overview]
Message-ID: <4F46295E.40000@monstr.eu> (raw)
In-Reply-To: <bb9023f48486da009a4e68a645f8514a4c7b37e7.1327848193.git.linz@li-pro.net>

Stephan Linz wrote:
> Signed-off-by: Stephan Linz <linz@li-pro.net>
> ---
>  .../xilinx/microblaze-generic/microblaze-generic.c |   57 ++++++++++++++++++++
>  drivers/net/xilinx_ll_temac.c                      |    2 +-
>  include/xilinx_ll_temac.h                          |    3 +
>  3 files changed, 61 insertions(+), 1 deletions(-)
> 
> diff --git a/board/xilinx/microblaze-generic/microblaze-generic.c b/board/xilinx/microblaze-generic/microblaze-generic.c
> index 517b2f1..d2f56b9 100644
> --- a/board/xilinx/microblaze-generic/microblaze-generic.c
> +++ b/board/xilinx/microblaze-generic/microblaze-generic.c
> @@ -31,6 +31,10 @@
>  #include <asm/microblaze_intc.h>
>  #include <asm/asm.h>
>  
> +#ifdef CONFIG_XILINX_LL_TEMAC
> +#include <xilinx_ll_temac.h>
> +#endif
> +
>  int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>  {
>  #ifdef CONFIG_SYS_GPIO_0
> @@ -92,7 +96,60 @@ int board_eth_init(bd_t *bis)
>  #endif
>  
>  #ifdef CONFIG_XILINX_LL_TEMAC
> +#if 1
> +	/* This should be the preferred way to initialize
> +	 * all the interfaces. */
>  	ret |= xilinx_ll_temac_standard_init(bis);

if 1 is not the best for mainline because it means that below is dead code.

Michal

-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian

  reply	other threads:[~2012-02-23 11:56 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-29 15:51 [U-Boot] [PREVIEW] LL TEMAC v10 refactored -- for evaluation only Stephan Linz
2012-01-29 15:54 ` [U-Boot] [PATCH 1/8] net: ll_temac: Add LL TEMAC driver to u-boot Stephan Linz
2012-02-23 11:57   ` Michal Simek
2012-01-29 15:54 ` [U-Boot] [PATCH 2/8] microblaze: Enable several ethernet driver compilation Stephan Linz
2012-01-31  9:00   ` Michal Simek
2012-01-31 19:05     ` Stephan Linz
2012-02-23 11:49   ` Michal Simek
2012-01-29 15:54 ` [U-Boot] [PATCH 3/8] microblaze: Enable phylib and mii support Stephan Linz
2012-02-23 11:52   ` Michal Simek
2012-01-29 15:54 ` [U-Boot] [PATCH 4/8] microblaze: Enable TFTP put command Stephan Linz
2012-02-23 11:51   ` Michal Simek
2012-01-29 15:54 ` [U-Boot] [PATCH 5/8] microblaze: Xilinx BSP to U-Boot conversion matrix Stephan Linz
2012-01-29 15:54 ` [U-Boot] [PATCH 6/8] microblaze: Add faked LL_TEMAC driver configuration Stephan Linz
2012-01-31  9:01   ` Michal Simek
2012-01-31 19:27     ` Stephan Linz
2012-02-23 11:53   ` Michal Simek
2012-01-29 15:54 ` [U-Boot] [PATCH 7/8] microblaze: Wire up LL_TEMAC driver initialization Stephan Linz
2012-01-29 15:54 ` [U-Boot] [PATCH 8/8] microblaze: ll_temac: export xilinx_ll_temac_eth_init() for evaluation Stephan Linz
2012-02-23 11:56   ` Michal Simek [this message]
2012-02-23 19:02     ` Stephan Linz
2012-02-23 12:22 ` [U-Boot] [PREVIEW] LL TEMAC v10 refactored -- for evaluation only Michal Simek
2012-02-23 19:39   ` Stephan Linz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F46295E.40000@monstr.eu \
    --to=monstr@monstr.eu \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.