From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Christian_K=F6nig?= Subject: Re: [PATCH 1/4] drm/radeon: move ring syncing after bo validation Date: Thu, 23 Feb 2012 19:27:34 +0100 Message-ID: <4F468516.2010205@vodafone.de> References: <1330006725-2373-1-git-send-email-deathsimple@vodafone.de> <1387209.zHcf9HjvNQ@notebook> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1374771151==" Return-path: Received: from outgoing.email.vodafone.de (outgoing.email.vodafone.de [139.7.28.128]) by gabe.freedesktop.org (Postfix) with ESMTP id 7D2439EF5A for ; Thu, 23 Feb 2012 10:27:37 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Jerome Glisse Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org This is a multi-part message in MIME format. --===============1374771151== Content-Type: multipart/alternative; boundary="------------020409010808040403040408" This is a multi-part message in MIME format. --------------020409010808040403040408 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable On 23.02.2012 18:32, Jerome Glisse wrote: > 2012/2/23 Mathias Fr=F6hlich > > > > Christian, > > On Thursday, February 23, 2012 15:18:42 Christian K=F6nig wrote: > > The function radeon_bo_list_validate can cause a > > bo to move, resulting in a different sync_obj > > and a dependency to wait for this move to finish. > > > > Signed-off-by: Christian K=F6nig > > > Reviewed-by: Alex Deucher > > > I am not sure, but to me this looks like this could fix these kind > of gpu > lockups that I experience since some time every now and then. > The usual symptom is that I get the > > radeon 0000:01:00.0: GPU lockup CP stall for more than 10000msec > GPU lockup (waiting for 0x00682AC3 last fence id 0x00682AC2) > [...] > > kernel message. Each time with the fence being off by one like in > the example > above. > > If this change has the potential to fix this issue I think this > particular > patch should be considered for the current upstream kernel release. > > Mathias > > > No this patch doesn't. This patch is all about getting proper sync btw=20 > different rings. That's unfortunately true, since we wasn't able to release any code that=20 makes direct use of the different rings (yet) it shouldn't really matter=20 in practice. I Just wanted to have that fix upstream since it is an=20 obvious bug. Christian. > > Sorry for the deception. > > Cheers, > Jerome --------------020409010808040403040408 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On 23.02.2012 18:32, Jerome Glisse wrote:
2012/2/23 Mathias Fröhlich <Mathias.Froehlich@gmx.net>

Christian,

On Thursday, February 23, 2012 15:18:42 Christian König wrote:
> The function radeon_bo_list_validate can cause a
> bo to move, resulting in a different sync_obj
> and a dependency to wait for this move to finish.
>
> Signed-off-by: Christian König <deathsimple@vodafone.de>
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

I am not sure, but to me this looks like this could fix these kind of gpu
lockups that I experience since some time every now and then.
The usual symptom is that I get the

radeon 0000:01:00.0: GPU lockup CP stall for more than 10000msec
GPU lockup (waiting for 0x00682AC3 last fence id 0x00682AC2)
[...]

kernel message. Each time with the fence being off by one like in the example
above.

If this change has the potential to fix this issue I think this particular
patch should be considered for the current upstream kernel release.

Mathias

No this patch doesn't. This patch is all about getting proper sync btw different rings.
That's unfortunately true, since we wasn't able to release any code that makes direct use of the different rings (yet) it shouldn't really matter in practice. I Just wanted to have that fix upstream since it is an obvious bug.

Christian.

Sorry for the deception.

Cheers,
Jerome

--------------020409010808040403040408-- --===============1374771151== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1374771151==--