From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Cousson, Benoit" Subject: Re: [PATCH 5/6] ARM: OMAP4: suspend: Do not get dsp/tesla out of reset Date: Thu, 23 Feb 2012 21:44:40 +0100 Message-ID: <4F46A538.80008@ti.com> References: <1330003320-17400-1-git-send-email-t-kristo@ti.com> <1330003320-17400-6-git-send-email-t-kristo@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from bear.ext.ti.com ([192.94.94.41]:46140 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932115Ab2BWUop (ORCPT ); Thu, 23 Feb 2012 15:44:45 -0500 In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Shilimkar, Santosh" Cc: Tero Kristo , linux-omap@vger.kernel.org, khilman@ti.com, linux-arm-kernel@lists.infradead.org, Rajendra Nayak On 2/23/2012 2:56 PM, Shilimkar, Santosh wrote: > $Subject > s/dsp/DSP > s/tesla/TESLA Even better... remove tesla :-) This is an internal codename that at some point should be removed from the clkdm name. I just did not have the time to do that for OMAP4, but it will not exist anymore on OMAP5. Nit: The subject should be: "ARM: OMAP4: hwmod data: Do not get DSP out of reset at boot time" Regards, Benoit > > On Thu, Feb 23, 2012 at 6:51 PM, Tero Kristo wrote: >> From: Rajendra Nayak >> >> With no driver handling DSP/TESLA, if brought out of reset, it stays >> active and does not assert standby. >> > Which lead to IVHA PD not transitiong and hence gating CHIP retention. > You may want to add these bits as well. > >> Signed-off-by: Rajendra Nayak >> Signed-off-by: Tero Kristo >> --- > > Patch is fine though script needs to be updated I guess > > Regards > Santosh > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: b-cousson@ti.com (Cousson, Benoit) Date: Thu, 23 Feb 2012 21:44:40 +0100 Subject: [PATCH 5/6] ARM: OMAP4: suspend: Do not get dsp/tesla out of reset In-Reply-To: References: <1330003320-17400-1-git-send-email-t-kristo@ti.com> <1330003320-17400-6-git-send-email-t-kristo@ti.com> Message-ID: <4F46A538.80008@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2/23/2012 2:56 PM, Shilimkar, Santosh wrote: > $Subject > s/dsp/DSP > s/tesla/TESLA Even better... remove tesla :-) This is an internal codename that at some point should be removed from the clkdm name. I just did not have the time to do that for OMAP4, but it will not exist anymore on OMAP5. Nit: The subject should be: "ARM: OMAP4: hwmod data: Do not get DSP out of reset at boot time" Regards, Benoit > > On Thu, Feb 23, 2012 at 6:51 PM, Tero Kristo wrote: >> From: Rajendra Nayak >> >> With no driver handling DSP/TESLA, if brought out of reset, it stays >> active and does not assert standby. >> > Which lead to IVHA PD not transitiong and hence gating CHIP retention. > You may want to add these bits as well. > >> Signed-off-by: Rajendra Nayak >> Signed-off-by: Tero Kristo >> --- > > Patch is fine though script needs to be updated I guess > > Regards > Santosh > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html