Re: [PATCH] Use MDMON_DIR for pid files created in Monitor.c

[Jes Sorensen <Jes.Sorensen@redhat.com>]

On 02/23/12 21:39, CoolCold wrote:
> On Thu, Feb 2, 2012 at 3:45 PM,  <Jes.Sorensen@redhat.com> wrote:
>> > From: Jes Sorensen <Jes.Sorensen@redhat.com>
>> >
>> > Other parts of mdadm/mdmon place .pid/.sock files in MDMON_DIR. This
>> > makes Monitor.c consistent with the rest.
>> >
>> > Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
>> > ---
>> >  Monitor.c |    8 +++++---
>> >  1 files changed, 5 insertions(+), 3 deletions(-)
>> >
>> > diff --git a/Monitor.c b/Monitor.c
>> > index 77f22aa..7ed5282 100644
>> > --- a/Monitor.c
>> > +++ b/Monitor.c
>> > @@ -294,8 +294,10 @@ static int check_one_sharer(int scan)
>> >        int pid, rv;
>> >        FILE *fp;
>> >        char dir[20];
>> > +       char path[100];
> Just wondering why not something like PATH_MAX or similar constant? I
> guess there should be one, though 100 should be enough

I used 100 here because it was consistent with how it is handled
elsewhere in the code. Having a constant would be fine with me, as long
as it is applied consistently.

Jes