All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Chou <thomas@wytron.com.tw>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] nios2-generic: Fix logic around choosing UART
Date: Fri, 24 Feb 2012 09:49:23 +0800	[thread overview]
Message-ID: <4F46ECA3.9020206@wytron.com.tw> (raw)
In-Reply-To: <4F41FA1E.3000701@alexhornung.com>

On 02/20/2012 03:45 PM, Alex Hornung wrote:
> On 20/02/12 07:33, Alex Hornung wrote:
>>   * Before, the normal altera UART driver was compiled in unconditionally
>>     and the JTAG UART was missed out.
>>
>>   * Work around this by conditionalizing the driver to use based on the
>>     UART choice in the user's custom FPGA header file. If both were to be
>>     present, the JTAG UART would have preference.

Dear Alex,

The preference of jtag uart is not always true. Some people prefer 
normal uart as it doesn't require the nios2-termial program. As it could 
be switched easily with a #define CONFIG_ALTERA_JTAG_UART per board 
config file, this patch is not accepted. Thank you anyway.

Best regards,
Thomas

      reply	other threads:[~2012-02-24  1:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-20  7:33 [U-Boot] [PATCH 1/2] nios2-generic: Fix logic around choosing UART Alex Hornung
2012-02-20  7:45 ` Alex Hornung
2012-02-24  1:49   ` Thomas Chou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F46ECA3.9020206@wytron.com.tw \
    --to=thomas@wytron.com.tw \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.