Re: LG VX8360 HFP non-compliance issue

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1105 bytes --]

Hi Mike,

On 02/23/2012 06:49 PM, Mike wrote:
> I'm getting weird behaviour from an LG VX8360, connected via bluetooth
> HFP.  When the phone connects, I see a CallAdded signal go out over
> dbus, despite there being no call on the phone itself.  You can see
> the signal below.  The LineIdentification held the actual phone number
> of the phone, but I replaced it with "xxxxxxxxxx".  I also copied in
> the initial RFCOMM communication.  It looks to me like this phone does
> not comply with the HFP spec in that it returns an answer to AT+CLCC
> when there is no phone call present (and at that, an index of 0).  It
> also happens that the status is a 6, which does not appear to be a
> valid status in HFPv1.5.  This just happens to map to the enum
> CALL_STATUS_DISCONNECTED, but I'm guessing this was merely
> coincidence.  Since the state is broadcast as disconnected, I can
> simply ignore it in my GUI application.  However, I'm wondering if
> this is something that is better handled in the ofono side?
> 
> Thanks,
> Mike
> 

Try the following patch.

Regards,
-Denis

[-- Attachment #2: 0001-atutil-Ignore-invalid-CLCC-results.patch --]
[-- Type: text/plain, Size: 1057 bytes --]

>From 9591a7768d91314e8b72c1e93f510860bbff1d04 Mon Sep 17 00:00:00 2001
From: Denis Kenzior <denkenz@gmail.com>
Date: Thu, 23 Feb 2012 23:14:08 -0600
Subject: [PATCH] atutil: Ignore invalid CLCC results

Some phones report CLCC calls with out-of-range info.  E.g. call index
being 0 (it is 1 based according to 27.007) and call states being
reported as '6' (valid call states are 0-5.)
---
 drivers/atmodem/atutil.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/drivers/atmodem/atutil.c b/drivers/atmodem/atutil.c
index b82ed20..0c6aab4 100644
--- a/drivers/atmodem/atutil.c
+++ b/drivers/atmodem/atutil.c
@@ -131,12 +131,18 @@ GSList *at_util_parse_clcc(GAtResult *result)
 		if (!g_at_result_iter_next_number(&iter, &id))
 			continue;
 
+		if (id == 0)
+			continue;
+
 		if (!g_at_result_iter_next_number(&iter, &dir))
 			continue;
 
 		if (!g_at_result_iter_next_number(&iter, &status))
 			continue;
 
+		if (status > 5)
+			continue;
+
 		if (!g_at_result_iter_next_number(&iter, &type))
 			continue;
 
-- 
1.7.3.4