From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rajendra Nayak Subject: Re: [PATCH 2/6] ARM: OMAP4 PM: Add IO Daisychain support Date: Fri, 24 Feb 2012 12:29:42 +0530 Message-ID: <4F47355E.3090107@ti.com> References: <1330003320-17400-1-git-send-email-t-kristo@ti.com> <1330003320-17400-3-git-send-email-t-kristo@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from na3sys009aog102.obsmtp.com ([74.125.149.69]:43992 "EHLO na3sys009aog102.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753270Ab2BXG7v (ORCPT ); Fri, 24 Feb 2012 01:59:51 -0500 Received: by yenr5 with SMTP id r5so993804yen.6 for ; Thu, 23 Feb 2012 22:59:49 -0800 (PST) In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Shilimkar, Santosh" Cc: Tero Kristo , linux-omap@vger.kernel.org, khilman@ti.com, linux-arm-kernel@lists.infradead.org, Vishwanath BS , "Dhavlikar, Nilesh" On Thursday 23 February 2012 07:18 PM, Shilimkar, Santosh wrote: > On Thu, Feb 23, 2012 at 6:51 PM, Tero Kristo wrote: [..] >> >> +/** >> + * Maximum time(us) it takes to output the signal WUCLKOUT of the last pad of >> + * the I/O ring after asserting WUCLKIN high >> + */ >> +#define MAX_IOPAD_LATCH_TIME 1000 >> + > Is the 1000 us/ms ? 1000 us. > Is that documented or arbitrary chosen ? looks like it was arbitrarily chosen as there's no documentation on the worst case delay. I spoke to Nilesh (copied) and he suggested using a value close to 100us instead which should be quite safe. 1000us according to him is really very high. however there does not seem to be any documented value available for this in any of the specs. > > Rest of the change looks good to me. > > regards > santosh From mboxrd@z Thu Jan 1 00:00:00 1970 From: rnayak@ti.com (Rajendra Nayak) Date: Fri, 24 Feb 2012 12:29:42 +0530 Subject: [PATCH 2/6] ARM: OMAP4 PM: Add IO Daisychain support In-Reply-To: References: <1330003320-17400-1-git-send-email-t-kristo@ti.com> <1330003320-17400-3-git-send-email-t-kristo@ti.com> Message-ID: <4F47355E.3090107@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thursday 23 February 2012 07:18 PM, Shilimkar, Santosh wrote: > On Thu, Feb 23, 2012 at 6:51 PM, Tero Kristo wrote: [..] >> >> +/** >> + * Maximum time(us) it takes to output the signal WUCLKOUT of the last pad of >> + * the I/O ring after asserting WUCLKIN high >> + */ >> +#define MAX_IOPAD_LATCH_TIME 1000 >> + > Is the 1000 us/ms ? 1000 us. > Is that documented or arbitrary chosen ? looks like it was arbitrarily chosen as there's no documentation on the worst case delay. I spoke to Nilesh (copied) and he suggested using a value close to 100us instead which should be quite safe. 1000us according to him is really very high. however there does not seem to be any documented value available for this in any of the specs. > > Rest of the change looks good to me. > > regards > santosh