From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: The submenu command shows a text-based menu when using a GFX theme.
Date: Fri, 24 Feb 2012 08:44:34 +0100 [thread overview]
Message-ID: <4F473FE2.7050301@gmail.com> (raw)
In-Reply-To: <1330046651.95459.YahooMailNeo@web113503.mail.gq1.yahoo.com>
On 24.02.2012 02:24, Towheed Mohammed wrote:
> While 'export theme' fixes the issue more elegantly than what I had, it still results in the theme reloading when the submenu menuentry is selected. Reloading of the theme results in a screen flicker as the terminal window is shown before the theme reloads.
>
> I cannot code in C nor do I profess to be anywhere close to scripting as you guys, but I think a better solution to fixing the submenu issue would be from source code.
>
> Is it at all possible to simply load the menuentry items under the submenu command without having to reload the entire theme? If it can be done, wouldn't it prevent the flicker seen as the theme reloads?
Problem is that it's possible to do something like:
submenu "xyz" {
theme=...
}
And thus change the theme for submenu.
> While at it, could you also please fix the keyboard lag that results when a gfx theme is used. This is an issue with many users of gfx themes .
>
> Thank you.
>
> Towheed Mohammed
>
> ----- Original Message -----
> From: Vladimir 'φ-coder/phcoder' Serbinenko<phcoder@gmail.com>
> To: grub-devel@gnu.org
> Cc:
> Sent: Thursday, February 23, 2012 1:24 AM
> Subject: Re: The submenu command shows a text-based menu when using a GFX theme.
>
> On 23.02.2012 02:50, Towheed Mohammed wrote:
>> If a gfx theme is being used and the submenu command is used to show a submenu, the submenu does not use the gfx theme. Instead a text-based menu is shown. The only way a regular user can workaround this at the moment is to reload the theme after the submenu menuentry item is selected.
>>
>> In Ubuntu's (about the only distro that uses the submenu command at this time) use of the submenu in 10_linux:
>>
>> if [ "$list" ]&& ! $in_submenu; then
>> in_submenu=:
>> fi
>>
>> A regular user must patch 10_linux thus:
>>
>> if [ "$list" ]&& ! $in_submenu; then
>> echo "submenu \"Previous Linux versions\" --class submenu {"
>> if [ "x$GRUB_THEME" != x ]&& [ -f "$GRUB_THEME" ] \
>> && is_path_readable_by_grub "$GRUB_THEME"; then
>> prepare_grub_to_access_device `${grub_probe} --target=device "$GRUB_THEME"`
>> cat<< EOF
>> set theme=(\$root)`make_system_path_relative_to_its_root $GRUB_THEME`
>> EOF
>> fi
>> in_submenu=:
>> fi
> What a perfect example of overengineering just to compensate for missing
> "export theme". I've fixed it in trunk
>> to reload the theme and have a themed submenu.
>>
>> Will this be fixed in the 2.00 release?
>>
>>
>> _______________________________________________
>> Grub-devel mailing list
>> Grub-devel@gnu.org
>> https://lists.gnu.org/mailman/listinfo/grub-devel
>>
>
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
next prev parent reply other threads:[~2012-02-24 7:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 1:50 The submenu command shows a text-based menu when using a GFX theme Towheed Mohammed
2012-02-23 5:24 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-02-24 1:24 ` Towheed Mohammed
2012-02-24 7:44 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2012-02-24 22:50 ` Towheed Mohammed
2012-02-24 23:03 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-02-26 2:18 ` Towheed Mohammed
2012-02-26 9:27 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-02-26 16:20 ` Towheed Mohammed
2012-02-26 16:50 ` Bruce Dubbs
2012-02-26 17:02 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-02-26 17:31 ` Towheed Mohammed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F473FE2.7050301@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.