From: Sergei Shtylyov <sshtylyov@mvista.com>
To: John Crispin <blogic@openwrt.org>
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Subject: Re: [PATCH V2 07/14] MIPS: lantiq: convert gpio_stp driver to clkdev api
Date: Fri, 24 Feb 2012 14:46:56 +0400 [thread overview]
Message-ID: <4F476AA0.7030703@mvista.com> (raw)
In-Reply-To: <1330012993-13510-7-git-send-email-blogic@openwrt.org>
Hello.
On 23-02-2012 20:03, John Crispin wrote:
> Update from old pmu_{dis,en}able() to ckldev api.
> Signed-off-by: John Crispin<blogic@openwrt.org>
[...]
> diff --git a/arch/mips/lantiq/xway/gpio_stp.c b/arch/mips/lantiq/xway/gpio_stp.c
> index e6b4809..8e07958 100644
> --- a/arch/mips/lantiq/xway/gpio_stp.c
> +++ b/arch/mips/lantiq/xway/gpio_stp.c
[...]
> @@ -105,7 +108,9 @@ static int ltq_stp_hw_init(void)
> */
> ltq_stp_w32_mask(0, LTQ_STP_ADSL_SRC, LTQ_STP_CON0);
>
> - ltq_pmu_enable(PMU_LED);
> + clk = clk_get(dev, NULL);
> + WARN_ON(!clk);
clk_get() returns error, not NULL.
WBR, Sergei
next prev parent reply other threads:[~2012-02-24 10:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 16:03 [PATCH V2 01/14] MIPS: add clkdev.h John Crispin
2012-02-23 16:03 ` [PATCH V2 02/14] MIPS: lantiq: helper functions for SoC detection John Crispin
2012-02-23 16:03 ` [PATCH V2 03/14] MIPS: lantiq: convert to clkdev api John Crispin
2012-02-23 16:03 ` [PATCH V2 04/14] MIPS: lantiq: convert xway " John Crispin
2012-02-23 16:03 ` [PATCH V2 05/14] MIPS: lantiq: convert falcon " John Crispin
2012-02-23 16:03 ` [PATCH V2 06/14] MIPS: lantiq: convert dma driver " John Crispin
2012-02-23 16:03 ` [PATCH V2 07/14] MIPS: lantiq: convert gpio_stp " John Crispin
2012-02-24 10:46 ` Sergei Shtylyov [this message]
2012-02-23 16:03 ` [PATCH V2 08/14] MIPS: lantiq: convert falcon gpio " John Crispin
2012-02-24 10:45 ` Sergei Shtylyov
2012-02-23 16:03 ` [PATCH V2 09/14] SERIAL: MIPS: lantiq: convert serial driver " John Crispin
2012-02-23 16:03 ` [PATCH V2 10/14] MIPS: lantiq: convert falcon debug uart " John Crispin
2012-02-24 10:53 ` Sergei Shtylyov
2012-02-23 16:03 ` [PATCH V2 11/14] NET: MIPS: lantiq: convert etop driver " John Crispin
2012-02-24 8:28 ` David Miller
2012-02-24 8:40 ` John Crispin
2012-02-24 8:53 ` David Miller
2012-02-24 10:55 ` Sergei Shtylyov
2012-02-23 16:03 ` [PATCH V2 12/14] WDT: MIPS: lantiq: convert watchdog " John Crispin
2012-02-23 16:03 ` [PATCH V2 13/14] MIPS: lantiq: unify xway prom code John Crispin
2012-02-23 16:03 ` [PATCH V2 14/14] MIPS: lantiq: add vr9 support John Crispin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F476AA0.7030703@mvista.com \
--to=sshtylyov@mvista.com \
--cc=blogic@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.