From: Aneesh V <aneesh@ti.com>
To: "Cousson, Benoit" <b-cousson@ti.com>
Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: [RFC PATCH 4/8] misc: emif: add basic infrastructure for EMIF driver
Date: Fri, 24 Feb 2012 16:40:20 +0530 [thread overview]
Message-ID: <4F47701C.2090305@ti.com> (raw)
In-Reply-To: <4F3D2F2F.8050406@ti.com>
On Thursday 16 February 2012 10:00 PM, Cousson, Benoit wrote:
> Hi Aneesh,
>
[...]
>> +struct emif_data {
>> + u8 duplicate;
>> + u8 temperature_level;
>> + u32 irq;
>> + spinlock_t lock; /* lock to prevent races */
>
> Nit: That comment is useless, since you already have the kerneldoc comment before.
Now I remember why I did that. Without that comment checkpatch gives
this "check".
CHECK: spinlock_t definition without comment
#124: FILE: drivers/misc/emif.c:54:
+ spinlock_t lock;
br,
Aneesh
next prev parent reply other threads:[~2012-02-24 11:10 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-04 12:16 [RFC PATCH 0/8] Add TI EMIF SDRAM controller driver Aneesh V
2012-02-04 12:16 ` [RFC PATCH 1/8] OMAP4: hwmod: add EMIF hw mod data Aneesh V
2012-02-16 10:02 ` Santosh Shilimkar
2012-02-16 10:27 ` Aneesh V
2012-02-04 12:16 ` [RFC PATCH 2/8] misc: ddr: add LPDDR2 data from JESD209-2 Aneesh V
2012-02-16 10:06 ` Santosh Shilimkar
2012-02-16 10:07 ` Santosh Shilimkar
2012-02-16 10:27 ` Aneesh V
2012-02-16 11:10 ` Alan Cox
2012-02-16 11:25 ` Shilimkar, Santosh
2012-02-16 11:55 ` Aneesh V
2012-02-04 12:16 ` [RFC PATCH 3/8] misc: emif: add register definitions for EMIF Aneesh V
2012-02-16 10:10 ` Santosh Shilimkar
2012-02-16 10:30 ` Aneesh V
2012-02-04 12:16 ` [RFC PATCH 4/8] misc: emif: add basic infrastructure for EMIF driver Aneesh V
2012-02-16 10:33 ` Santosh Shilimkar
2012-02-16 11:15 ` Aneesh V
2012-02-16 16:30 ` Cousson, Benoit
2012-02-16 16:30 ` Cousson, Benoit
2012-02-17 13:26 ` Aneesh V
2012-02-17 13:44 ` Cousson, Benoit
2012-02-17 13:44 ` Cousson, Benoit
2012-02-17 15:27 ` Aneesh V
2012-02-24 11:10 ` Aneesh V [this message]
2012-02-24 11:16 ` Cousson, Benoit
2012-02-24 11:16 ` Cousson, Benoit
2012-02-04 12:16 ` [RFC PATCH 5/8] misc: emif: handle frequency and voltage change events Aneesh V
2012-02-16 10:38 ` Santosh Shilimkar
2012-02-16 11:22 ` Aneesh V
2012-02-04 12:16 ` [RFC PATCH 6/8] misc: emif: add interrupt and temperature handling Aneesh V
2012-02-16 10:41 ` Santosh Shilimkar
2012-02-16 11:50 ` Aneesh V
2012-02-04 12:16 ` [RFC PATCH 7/8] misc: emif: add one-time settings Aneesh V
2012-02-16 10:44 ` Santosh Shilimkar
2012-02-16 11:56 ` Aneesh V
2012-02-04 12:16 ` [RFC PATCH 8/8] misc: emif: add debugfs entries for emif Aneesh V
2012-02-16 10:46 ` Santosh Shilimkar
2012-02-16 10:51 ` [RFC PATCH 0/8] Add TI EMIF SDRAM controller driver Santosh Shilimkar
2012-02-16 16:23 ` Greg KH
2012-02-17 13:56 ` Aneesh V
2012-02-17 17:50 ` Greg KH
2012-02-20 14:07 ` Aneesh V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F47701C.2090305@ti.com \
--to=aneesh@ti.com \
--cc=akpm@linux-foundation.org \
--cc=b-cousson@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.