From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:35991)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S0vy7-0005EI-G0
	for qemu-devel@nongnu.org; Fri, 24 Feb 2012 09:17:59 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S0vy1-00026A-5z
	for qemu-devel@nongnu.org; Fri, 24 Feb 2012 09:17:55 -0500
Received: from cantor2.suse.de ([195.135.220.15]:41469 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S0vy0-00025p-RI
	for qemu-devel@nongnu.org; Fri, 24 Feb 2012 09:17:49 -0500
Message-ID: <4F479C0B.8030705@suse.de>
Date: Fri, 24 Feb 2012 15:17:47 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1330092792-22455-1-git-send-email-lcapitulino@redhat.com>
	<1330092792-22455-2-git-send-email-lcapitulino@redhat.com>
In-Reply-To: <1330092792-22455-2-git-send-email-lcapitulino@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/5] boards: qemu_register_machine():
 return void
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

Am 24.02.2012 15:13, schrieb Luiz Capitulino:
> It never fails.

...and is never checked. Low-impact cleanup, thanks.

>=20
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>

Reviewed-by: Andreas F=E4rber <afaerber@suse.de>

Andreas

> ---
>  hw/boards.h |    2 +-
>  vl.c        |    3 +--
>  2 files changed, 2 insertions(+), 3 deletions(-)
>=20
> diff --git a/hw/boards.h b/hw/boards.h
> index 667177d..7a9899f 100644
> --- a/hw/boards.h
> +++ b/hw/boards.h
> @@ -31,7 +31,7 @@ typedef struct QEMUMachine {
>      struct QEMUMachine *next;
>  } QEMUMachine;
> =20
> -int qemu_register_machine(QEMUMachine *m);
> +void qemu_register_machine(QEMUMachine *m);
>  QEMUMachine *find_default_machine(void);
> =20
>  extern QEMUMachine *current_machine;
> diff --git a/vl.c b/vl.c
> index 7a8cc08..45fc3b5 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -1163,7 +1163,7 @@ void pcmcia_info(Monitor *mon)
>  static QEMUMachine *first_machine =3D NULL;
>  QEMUMachine *current_machine =3D NULL;
> =20
> -int qemu_register_machine(QEMUMachine *m)
> +void qemu_register_machine(QEMUMachine *m)
>  {
>      QEMUMachine **pm;
>      pm =3D &first_machine;
> @@ -1171,7 +1171,6 @@ int qemu_register_machine(QEMUMachine *m)
>          pm =3D &(*pm)->next;
>      m->next =3D NULL;
>      *pm =3D m;
> -    return 0;
>  }
> =20
>  static QEMUMachine *find_machine(const char *name)

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg