From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34467) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0yTy-0000G3-GC for qemu-devel@nongnu.org; Fri, 24 Feb 2012 11:59:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S0yTu-0002dp-Ax for qemu-devel@nongnu.org; Fri, 24 Feb 2012 11:58:58 -0500 Received: from e7.ny.us.ibm.com ([32.97.182.137]:43429) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0yTu-0002dj-6z for qemu-devel@nongnu.org; Fri, 24 Feb 2012 11:58:54 -0500 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 24 Feb 2012 11:58:52 -0500 Received: from d01relay05.pok.ibm.com (d01relay05.pok.ibm.com [9.56.227.237]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 4702A38C8056 for ; Fri, 24 Feb 2012 11:57:47 -0500 (EST) Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com [9.17.195.85]) by d01relay05.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q1OGvkS4252360 for ; Fri, 24 Feb 2012 11:57:46 -0500 Received: from d03av05.boulder.ibm.com (loopback [127.0.0.1]) by d03av05.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q1OGvgBm007192 for ; Fri, 24 Feb 2012 09:57:42 -0700 Message-ID: <4F47C184.8090503@us.ibm.com> Date: Fri, 24 Feb 2012 10:57:40 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1330092792-22455-1-git-send-email-lcapitulino@redhat.com> <1330092792-22455-3-git-send-email-lcapitulino@redhat.com> <4F47B7B8.505@us.ibm.com> <20120224145151.53f5e1de@doriath.home> In-Reply-To: <20120224145151.53f5e1de@doriath.home> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/5] boards: rename machine type functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Peter Maydell , qemu-devel@nongnu.org On 02/24/2012 10:51 AM, Luiz Capitulino wrote: > On Fri, 24 Feb 2012 10:15:52 -0600 > Anthony Liguori wrote: > >> On 02/24/2012 10:12 AM, Peter Maydell wrote: >>> On 24 February 2012 14:13, Luiz Capitulino wrote: >>>> Perform the following renames: >>>> >>>> o qemu_register_machine() -> machine_register() >>>> o find_machine() -> machine_find() >>>> o find_default_machine() -> machine_find_default() >>>> >>>> Signed-off-by: Luiz Capitulino >>>> 52 files changed, 96 insertions(+), 96 deletions(-) >>> >>> I said I was going to nack the next change-whole-tree >>> change, so here it is: nack. >>> >>> At some point we're going to have to actually start >>> converting boards to be QOM objects themselves, but >>> (a) I hope we can make that incremental so we can do >>> things in batches the way we did with MemoryRegion >>> conversions and (b) until then the qemu_register_machine >>> rename just looks like unnecessary churn to me. >> >> I think I agree with you here. I don't see the value compared to the churn here >> given that we're going to have to touch all of this again anyway soon. > > Do you guys see value in patch 5/5, which moves the machine function to the > boards file? Yes. And it's not that the other practicals aren't useful, it's just that I agree with Peter's valid point that the churn outweighs the benefit right now. Regards, Anthony Liguori > > If you don't I'll keep only patch 1/5 (which can be submitted to qemu-trivial). >