From: Gerd Hoffmann <kraxel@redhat.com>
To: Christophe Fergeau <cfergeau@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCHv2 2/2] Error out when tls-channel option is used without TLS
Date: Fri, 24 Feb 2012 18:20:00 +0100 [thread overview]
Message-ID: <4F47C6C0.2040506@redhat.com> (raw)
In-Reply-To: <1330103593-11826-2-git-send-email-cfergeau@redhat.com>
On 02/24/12 18:13, Christophe Fergeau wrote:
> It's currently possible to setup spice channels using TLS when
> no TLS port has been specified (ie TLS is disabled). This cannot
> work, so better to error out in such a situation.
Applying: Error out when tls-channel option is used without TLS
=== checkpatch complains ===
WARNING: line over 80 characters
#12: FILE: ui/spice-core.c:531:
+ error_report("spice: tried to setup tls-channel without
specifying a TLS port\n");
total: 0 errors, 1 warnings, 19 lines checked
/tmp/tmp.9W76AGBT7O has style problems, please review. If any of these
errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
next prev parent reply other threads:[~2012-02-24 17:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 17:13 [Qemu-devel] [PATCHv2 1/2] spice: use error_report to report errors Christophe Fergeau
2012-02-24 17:13 ` [Qemu-devel] [PATCHv2 2/2] Error out when tls-channel option is used without TLS Christophe Fergeau
2012-02-24 17:20 ` Gerd Hoffmann [this message]
2012-02-24 17:28 ` [Qemu-devel] [PATCHv3] " Christophe Fergeau
2012-02-24 17:32 ` Gerd Hoffmann
2012-02-24 17:19 ` [Qemu-devel] [PATCHv2 1/2] spice: use error_report to report errors Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F47C6C0.2040506@redhat.com \
--to=kraxel@redhat.com \
--cc=cfergeau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.