Re: [PATCH] autotools.bbclass: Don't copy into non-existant directory

From: Saul Wold <sgw@linux.intel.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] autotools.bbclass: Don't copy into non-existant directory
Date: Fri, 24 Feb 2012 10:29:23 -0800	[thread overview]
Message-ID: <4F47D703.9080605@linux.intel.com> (raw)
In-Reply-To: <4F355B52.6050007@opendreambox.org>

On 02/10/2012 10:00 AM, Andreas Oberritter wrote:
> * If configure.ac contains AM_GNU_GETTEXT and po/Makefile.in.in
>    doesn't exist, autotools_do_configure() copies a local
>    version of Makefile.in.in to this location. If the directory
>    'po' doesn't exist, the function aborts.
>
> * This patch verifies that the directory exists before copying
>    a file to it. This fixes libcddb, which uses AM_GNU_GETTEXT,
>    but has no 'po' directory.
>
> Signed-off-by: Andreas Oberritter<obi@opendreambox.org>
> ---
>   meta/classes/autotools.bbclass |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta/classes/autotools.bbclass b/meta/classes/autotools.bbclass
> index 5d74333..e22ea68 100644
> --- a/meta/classes/autotools.bbclass
> +++ b/meta/classes/autotools.bbclass
> @@ -149,7 +149,7 @@ autotools_do_configure() {
>   			  else if grep "^[[:space:]]*AM_GNU_GETTEXT" $CONFIGURE_AC>/dev/null; then
>                               # We'd call gettextize here if it wasn't so broken...
>   			    cp ${STAGING_DATADIR}/gettext/config.rpath ${AUTOTOOLS_AUXDIR}/
> -			    if [ ! -e ${S}/po/Makefile.in.in ]; then
> +			    if [ -d ${S}/po/ -a ! -e ${S}/po/Makefile.in.in ]; then
>   			      cp ${STAGING_DATADIR}/gettext/po/Makefile.in.in ${S}/po/
>                               fi
>   			  fi
>
Merged into OE-core

Thanks
	Sau!

>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core